-
Notifications
You must be signed in to change notification settings - Fork 25
[Deps] Split up of dependencies #2364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e9bda84 to
e1fdf50
Compare
41edac3 to
63606a8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2364 +/- ##
==========================================
+ Coverage 62.33% 62.39% +0.06%
==========================================
Files 157 157
Lines 13362 13451 +89
==========================================
+ Hits 8329 8393 +64
- Misses 5033 5058 +25 ☔ View full report in Codecov by Sentry. |
2f5f4eb to
1af0d82
Compare
1af0d82 to
7db3ee1
Compare
ca93cb5 to
d428984
Compare
d428984 to
b95d954
Compare
97083e8 to
30f95cf
Compare
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
30f95cf to
4a62e1b
Compare
9e9cbf3 to
5a73c58
Compare
5a73c58 to
a994bd5
Compare
- Cherry-picked setup.py fix (commit 171c063ab) onto main commit 19ee67f674b2ea05e38531162f49885dcf4ad9d4 - This resolves the SameFileError during tt_tvm wheel build - Maintains compatibility with main branch expectations
- Cherry-picked setup.py fix (commit 171c063ab) onto main commit 25c5feec112a33f5dfba1916b6e8a50ea9544bf5 - This resolves the SameFileError during tt_tvm wheel build - Maintains compatibility with main branch expectations - Only TVM submodule updated
5d41948 to
354a07c
Compare
Resolves GitHub conflict detection while preserving TVM setup.py fix. TVM submodule updated to include SameFileError fix on latest main base.
- Use commit 25c5feec112a33f5dfba1916b6e8a50ea9544bf5 from main TVM repository - This commit is accessible by GitHub Actions CI - Previous custom commit 533f92d3b was not pushed to remote repository
|
Unit tests, Failure update: **Current Test Results: 15/31 PASSING **All consistently passing tests:
|
|
@nvukobratTT , **Problem ** :
Technical Details:
Solution added: |
ada131f to
0940461
Compare
| } | ||
| catch (...) | ||
| { | ||
| log_error(LogMLIRCompiler, "Unknown exception during MLIR pass registration"); |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
log_error
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To fix the problem, explicitly cast the call to log_error on line 89 to void. This documents that the value is intentionally ignored and the function is called for its side effect. This change should be made only to line 89 in forge/csrc/passes/mlir_passes.cpp. No imports or additional definitions are required.
-
Copy modified line R89
| @@ -86,7 +86,7 @@ | ||
| } | ||
| catch (...) | ||
| { | ||
| log_error(LogMLIRCompiler, "Unknown exception during MLIR pass registration"); | ||
| (void)log_error(LogMLIRCompiler, "Unknown exception during MLIR pass registration"); | ||
| throw; | ||
| } | ||
| } |
| } | ||
| catch (...) | ||
| { | ||
| log_error(LogMLIRCompiler, "Unknown error during MLIR pass registration"); |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
log_error
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To address the warning and clarify that the value of the expression is intentionally ignored (and that the function is called for its side effect), explicitly cast the call to log_error to (void). This is a common idiom in C/C++ to indicate that the return value is intentionally discarded, and it will silence static analysis tools like CodeQL. Only line 117 in forge/csrc/passes/mlir_passes.cpp needs to be changed:
- Replace:
log_error(LogMLIRCompiler, "Unknown error during MLIR pass registration"); - With:
(void)log_error(LogMLIRCompiler, "Unknown error during MLIR pass registration");
No new imports, methods, or definitions are needed.
-
Copy modified line R117
| @@ -114,7 +114,7 @@ | ||
| } | ||
| catch (...) | ||
| { | ||
| log_error(LogMLIRCompiler, "Unknown error during MLIR pass registration"); | ||
| (void)log_error(LogMLIRCompiler, "Unknown error during MLIR pass registration"); | ||
| registration_successful = false; | ||
| } | ||
| }); |
| // Verify registration was successful | ||
| if (!registration_successful.load()) | ||
| { | ||
| log_warning(LogMLIRCompiler, "MLIR pass registration was not successful"); |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
log_warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To fix the warning, explicitly cast the call to log_warning to (void). This documents that the return value is intentionally ignored and that the expression is used for its side effects (logging). This is a standard idiom in C/C++ to silence such warnings from static analysis tools.
Change:
- In
forge/csrc/passes/mlir_passes.cpp, line 125, change
log_warning(LogMLIRCompiler, "MLIR pass registration was not successful");
to
(void)log_warning(LogMLIRCompiler, "MLIR pass registration was not successful");
No new imports or definitions are needed.
-
Copy modified line R125
| @@ -122,7 +122,7 @@ | ||
| // Verify registration was successful | ||
| if (!registration_successful.load()) | ||
| { | ||
| log_warning(LogMLIRCompiler, "MLIR pass registration was not successful"); | ||
| (void)log_warning(LogMLIRCompiler, "MLIR pass registration was not successful"); | ||
| } | ||
| } | ||
|
|
| std::cout << "Setting up test environment..." << std::endl; | ||
|
|
||
| // Step 1: Setup environment variables | ||
| setup_llvm_environment(); |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
setup_llvm_environment
Copilot Autofix
AI 3 months ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
0940461 to
b0a8017
Compare
e3ee0cc to
c63762c
Compare
- Update openMeshDevice() call to match new API signature - meshShape is now passed as first parameter instead of options.meshShape - Resolves build error caused by TT-MLIR API changes in merge
c63762c to
ce1334c
Compare
3311765 to
c431091
Compare
…o sai_arthi_raguram/deps_split
bdb6481 to
8f64472
Compare
8f64472 to
ac88849
Compare
…thi_raguram/deps_split
…thi_raguram/deps_split
dfc798b to
a69f5b2
Compare
|
9/09/2025
Current Fix in docker env is to
|
Ticket
Fixes: Link to Github Issue
Problem description
dev-requirements - contains model based requirements
core-requirements - contains compiler based requirements
Changes
To-Do