Update CONTRIBUTING.md with DCO and CI info#162
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe pull request adds an [!IMPORTANT] note to CONTRIBUTING.md requiring a Developer Certificate of Origin (DCO) sign-off on every commit, with guidance to use ChangesDCO Governance Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CONTRIBUTING.md`:
- Around line 63-65: The commit message must be amended to match the repository
policy pattern and include a DCO sign-off: update the current commit (the one
that changed CONTRIBUTING.md) with a message following "[JIRA-TICKET] | [TYPE]:
<message>" (e.g., "OCM-00000 | docs: add DCO sign-off requirement") and include
the Signed-off-by line (use git commit --amend -s or add "Signed-off-by: Name
<email>" manually); this will satisfy the hack/commit-msg-verify.sh hook that
currently rejects "Update CONTRIBUTING.md with DCO and CI info".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 782ef602-38c4-4008-88cc-da0147d91ba3
📒 Files selected for processing (1)
CONTRIBUTING.md
| [!IMPORTANT] | ||
| DCO Sign-off Required: Every commit must include a Developer Certificate of Origin (DCO) sign-off line (Signed-off-by: Name <email>). Use git commit -s when committing. | ||
|
|
There was a problem hiding this comment.
Commit message format violation blocks merge.
The PR's commit message "Update CONTRIBUTING.md with DCO and CI info" does not follow the required format documented in this file. The commit must be amended to match [JIRA-TICKET] | [TYPE]: <message> (e.g., "OCM-00000 | docs: add DCO sign-off requirement" or a valid JIRA ticket if assigned). Additionally, once amended, it must include the DCO sign-off line (-s flag or manual Signed-off-by: line).
Pipeline validation (hack/commit-msg-verify.sh) will reject this commit until the format is corrected.
How to fix:
git commit --amend --no-edit
# Then update the commit message interactively to follow the format, or:
git commit --amend -m "OCM-00000 | docs: add DCO sign-off requirement" -s🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CONTRIBUTING.md` around lines 63 - 65, The commit message must be amended to
match the repository policy pattern and include a DCO sign-off: update the
current commit (the one that changed CONTRIBUTING.md) with a message following
"[JIRA-TICKET] | [TYPE]: <message>" (e.g., "OCM-00000 | docs: add DCO sign-off
requirement") and include the Signed-off-by line (use git commit --amend -s or
add "Signed-off-by: Name <email>" manually); this will satisfy the
hack/commit-msg-verify.sh hook that currently rejects "Update CONTRIBUTING.md
with DCO and CI info".
Source: Pipeline failures
Signed-off-by: Amanda H. L. de Andrade Katz <amanda.katz@redhat.com>
amandahla
force-pushed
the
amandahla-patch-1
branch
from
844d856 to
a1dfc8c
Compare
|
/override ci/prow/rosa-hcp-private |
|
@amandahla: Overrode contexts on behalf of amandahla: ci/prow/rosa-hcp-private, ci/prow/rosa-hcp-public DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amandahla, olucasfreitas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/rosa-hcp-private |
|
@amandahla: Overrode contexts on behalf of amandahla: ci/prow/rosa-hcp-private, ci/prow/rosa-hcp-public DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@amandahla: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Added DCO sign-off requirement and CI validation details.
PR Summary
Detailed Description of the Issue
Related Issues and PRs
#Type of Change
Previous Behavior
Behavior After This Change
How to Test (Step-by-Step)
Preconditions
Test Steps
Expected Results
Proof of the Fix
Breaking Changes
Breaking Change Details / Migration Plan
Developer Verification Checklist
rhcsresources/variables), I linked official Red Hat or cited ROSA HCP documentation that supports reference alignment, or I explained why the change still belongs in-repo perModule scope (AWS-only vs core HCP)in.cursor/rules/rosa-hcp-terraform.mdc.[JIRA-TICKET] | [TYPE]: <MESSAGE>.make pre-push-checkspasses (or each step:verify,verify-gen,lint,unit-tests,license-check,docs-lint).make terraform-docs).Summary by CodeRabbit