Skip to content

Update CONTRIBUTING.md with DCO and CI info #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jun 15, 2026
Merged

Update CONTRIBUTING.md with DCO and CI info #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ Allowed `TYPE` values:
- `ci`: Continuous integration changes
- `perf`: Performance improvements

[!IMPORTANT]
DCO Sign-off Required: Every commit must include a Developer Certificate of Origin (DCO) sign-off line (Signed-off-by: Name <email>). Use git commit -s when committing.

Comment on lines +63 to +65

@coderabbitai coderabbitai Bot Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Commit message format violation blocks merge.

The PR's commit message "Update CONTRIBUTING.md with DCO and CI info" does not follow the required format documented in this file. The commit must be amended to match [JIRA-TICKET] | [TYPE]: <message> (e.g., "OCM-00000 | docs: add DCO sign-off requirement" or a valid JIRA ticket if assigned). Additionally, once amended, it must include the DCO sign-off line (-s flag or manual Signed-off-by: line).

Pipeline validation (hack/commit-msg-verify.sh) will reject this commit until the format is corrected.

How to fix:

git commit --amend --no-edit
# Then update the commit message interactively to follow the format, or:
git commit --amend -m "OCM-00000 | docs: add DCO sign-off requirement" -s
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CONTRIBUTING.md` around lines 63 - 65, The commit message must be amended to
match the repository policy pattern and include a DCO sign-off: update the
current commit (the one that changed CONTRIBUTING.md) with a message following
"[JIRA-TICKET] | [TYPE]: <message>" (e.g., "OCM-00000 | docs: add DCO sign-off
requirement") and include the Signed-off-by line (use git commit --amend -s or
add "Signed-off-by: Name <email>" manually); this will satisfy the
hack/commit-msg-verify.sh hook that currently rejects "Update CONTRIBUTING.md
with DCO and CI info".

Source: Pipeline failures

CI validates commit messages on pull requests targeting `main` with:

- `.github/workflows/check-commit-format.yml`
Expand Down