Skip to content

feat(tart provider): Set the VM name for the tart provider#503

Open
barkingfoodog wants to merge 4 commits intotest-kitchen:mainfrom
barkingfoodog:tart-vm-name
Open

feat(tart provider): Set the VM name for the tart provider#503
barkingfoodog wants to merge 4 commits intotest-kitchen:mainfrom
barkingfoodog:tart-vm-name

Conversation

@barkingfoodog
Copy link
Copy Markdown

Description

Allows using test kitchen with the tart (https://github.com/cirruslabs/tart) provider (https://github.com/letiemble/vagrant-tart) for Vagrant.

Issues Resolved

None.

Type of Change

Our release process assumes you are using Conventional Commit messages.

The most important prefixes you should have in mind are:

  • _fix_: which represents bug fixes, and correlates to a SemVer patch.
  • _feat_: which represents a new feature, and correlates to a SemVer minor.
  • _feat!_:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a major version change.

If you have not included a conventional commit message this can be fixed on merge.

Check List

@damacus damacus requested a review from Copilot November 9, 2025 21:30
@damacus damacus changed the title Set the VM name for the tart provider fix: Set the VM name for the tart provider Nov 9, 2025
@damacus damacus changed the title fix: Set the VM name for the tart provider feat(tart provider): Set the VM name for the tart provider Nov 9, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the Tart virtualization provider by configuring its naming convention in the Vagrantfile template.

  • Adds a case block to set the provider name for the "tart" provider
  • Uses a naming pattern without UUID suffix, unlike VirtualBox which includes a random UUID

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread templates/Vagrantfile.erb
Comment on lines 100 to +103
<% end %>

<% case config[:provider]
when "tart" %>
Copy link

Copilot AI Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two separate case config[:provider] blocks setting p.name should be consolidated into a single case statement. This would improve code maintainability and follow the pattern used elsewhere in the file.

Consider merging them like this:

<% case config[:provider]
   when "virtualbox" %>
    p.name = "kitchen-<%= File.basename(config[:kitchen_root]) %>-<%= instance.name %>-<%= SecureRandom.uuid %>"
<% when "tart" %>
    p.name = "kitchen-<%= File.basename(config[:kitchen_root]) %>-<%= instance.name %>"
<% end %>
Suggested change
<% end %>
<% case config[:provider]
when "tart" %>
<% when "tart" %>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants