feat(tart provider): Set the VM name for the tart provider#503
Open
barkingfoodog wants to merge 4 commits intotest-kitchen:mainfrom
Open
feat(tart provider): Set the VM name for the tart provider#503barkingfoodog wants to merge 4 commits intotest-kitchen:mainfrom
barkingfoodog wants to merge 4 commits intotest-kitchen:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Tart virtualization provider by configuring its naming convention in the Vagrantfile template.
- Adds a case block to set the provider name for the "tart" provider
- Uses a naming pattern without UUID suffix, unlike VirtualBox which includes a random UUID
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
100
to
+103
| <% end %> | ||
|
|
||
| <% case config[:provider] | ||
| when "tart" %> |
There was a problem hiding this comment.
These two separate case config[:provider] blocks setting p.name should be consolidated into a single case statement. This would improve code maintainability and follow the pattern used elsewhere in the file.
Consider merging them like this:
<% case config[:provider]
when "virtualbox" %>
p.name = "kitchen-<%= File.basename(config[:kitchen_root]) %>-<%= instance.name %>-<%= SecureRandom.uuid %>"
<% when "tart" %>
p.name = "kitchen-<%= File.basename(config[:kitchen_root]) %>-<%= instance.name %>"
<% end %>
Suggested change
| <% end %> | |
| <% case config[:provider] | |
| when "tart" %> | |
| <% when "tart" %> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows using test kitchen with the tart (https://github.com/cirruslabs/tart) provider (https://github.com/letiemble/vagrant-tart) for Vagrant.
Issues Resolved
None.
Type of Change
Our release process assumes you are using Conventional Commit messages.
The most important prefixes you should have in mind are:
_fix_: which represents bug fixes, and correlates to a SemVer patch._feat_: which represents a new feature, and correlates to a SemVer minor._feat!_:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a major version change.If you have not included a conventional commit message this can be fixed on merge.
Check List