Skip to content

feat(tart provider): Set the VM name for the tart provider #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barkingfoodog wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(tart provider): Set the VM name for the tart provider #503

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2af264
Set the VM name for the tart provider
barkingfoodog Jun 23, 2025
2e5db04
Omit uuid from name for tart. This allows subsequent kitchen runs to …
barkingfoodog Jun 23, 2025
f038cab
Merge branch 'main' into tart-vm-name
tas50 Sep 22, 2025
8e1a9e6
Merge branch 'main' into tart-vm-name
damacus Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions templates/Vagrantfile.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ Vagrant.configure("2") do |c|
p.name = "kitchen-<%= File.basename(config[:kitchen_root]) %>-<%= instance.name %>-<%= SecureRandom.uuid %>"
<% end %>

<% case config[:provider]
when "tart" %>
Comment on lines 100 to +103
Copy link

Copilot AI Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two separate case config[:provider] blocks setting p.name should be consolidated into a single case statement. This would improve code maintainability and follow the pattern used elsewhere in the file.

Consider merging them like this:

<% case config[:provider]
   when "virtualbox" %>
    p.name = "kitchen-<%= File.basename(config[:kitchen_root]) %>-<%= instance.name %>-<%= SecureRandom.uuid %>"
<% when "tart" %>
    p.name = "kitchen-<%= File.basename(config[:kitchen_root]) %>-<%= instance.name %>"
<% end %>
Suggested change
<% end %>
<% case config[:provider]
when "tart" %>
<% when "tart" %>

Copilot uses AI. Check for mistakes.
p.name = "kitchen-<%= File.basename(config[:kitchen_root]) %>-<%= instance.name %>"
<% end %>

<% case config[:provider]
when "virtualbox", /^vmware_/
if config[:gui] == true || config[:gui] == false %>
Expand Down
Loading