feat(Oracle): Add support for WithDatabase(string) for Oracle 18 and onwards

[0xced]

What does this PR do?

This pull request selects the correct database default name depending on the Docker image version and enable setting a custom database name for Oracle 18 and onwards.

Why is it important?

This enables using the new Oracle Docker images (e.g. gvenzl/oracle-free) which doesn't work with the current implementation because of the hardcoded XEPDB1 default database.

Note

The gvenzl/oracle-free image is the first one with arm64 support which is especially interesting for macOS users.

Related issues

• Closes [Enhancement]: Allow Oracle container builder to set the database name #1233
• Relates [Enhancement]: Support new oracle/free image with ARM support #1329

How to test this PR

The OracleContainerTest class has been augmented to test many variations of the Oracle Docker images.

• gvenzl/oracle-xe:11
• gvenzl/oracle-xe:18
• gvenzl/oracle-xe:21
• gvenzl/oracle-free:23

[netlify]

✅ Deploy Preview for testcontainers-dotnet ready!

Name	Link
🔨 Latest commit	9af66e2
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-dotnet/deploys/67b20f5482261b0008e80a37
😎 Deploy Preview	https://deploy-preview-1321--testcontainers-dotnet.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[0xced]

11 Oracle containers from 4 images and the GitHub runner fails with No space left on device 😖

[HofmeisterAn]

11 Oracle containers from 4 images and the GitHub runner fails with No space left on device 😖

It looks like we are right at the edge. Although I expected ~20GB to be enough, I thought the root filesystem had something like ~30GB left. Maybe we can save some MBs by restoring the NuGet cache on the temp disk, but that likely won't be enough too.

gvenzl/oracle-xe:11-slim-faststart 1.64GB
gvenzl/oracle-xe:18-slim-faststart 4.44GB
gvenzl/oracle-xe:21-slim-faststart 4.66GB
gvenzl/oracle-xe:21.3.0-slim-faststart 4.66GB
gvenzl/oracle-free:23-slim-faststart 4.62GB

What do you think about removing 18 and 21 (as we are most likely testing the same configurations)? Maybe that is enough already.

[0xced]

I tried something else that seems to work pretty well: splitting the Oracle tests into multiple projects so that we don't have the disk space issue.

Let's hope this can land into version 4.3.0. Mac users will be happy to be able to use the gvenzl/oracle-free:23 images!

I also just realised that the *-slim images are actually slim but that the *-slim-faststart images are not slim at all, what a misleading name!

image	size
gvenzl/oracle-free:23-slim	1.41 GB
gvenzl/oracle-free:23	2.19 GB
gvenzl/oracle-free:23-slim-faststart	4.37 GB
gvenzl/oracle-free:23-faststart	5.34 GB

So if you prefer to keep all the Oracle tests in the same project we might try the *-slim images instead of the *-slim-faststart images and we'll save quite some GBs!

[HofmeisterAn]

Cool idea utilizing the compiler constants 😎 I will try to review it tomorrow.

[jwedel]

I also just realised that the *-slim images are actually slim but that the *-slim-faststart images are not slim at all, what a misleading name!

image size
gvenzl/oracle-free:23-slim 1.41 GB
gvenzl/oracle-free:23 2.19 GB
gvenzl/oracle-free:23-slim-faststart 4.37 GB
gvenzl/oracle-free:23-faststart 5.34 GB
So if you prefer to keep all the Oracle tests in the same project we might try the *-slim images instead of the *-slim-faststart images and we'll save quite some GBs!

The faststart images have performed the installation process already which probably will involves some unpacking, hence the bigger image.

However, they start significantly faster which is key in integration tests.

Would this non fast start only be used in your own tests or also as default in the shipped lib?

if the latter, I would suggest to keep the slim fast start.

[HofmeisterAn]

I also just realised that the *-slim images are actually slim but that the *-slim-faststart images are not slim at all, what a misleading name!
image size
gvenzl/oracle-free:23-slim 1.41 GB
gvenzl/oracle-free:23 2.19 GB
gvenzl/oracle-free:23-slim-faststart 4.37 GB
gvenzl/oracle-free:23-faststart 5.34 GB
So if you prefer to keep all the Oracle tests in the same project we might try the *-slim images instead of the *-slim-faststart images and we'll save quite some GBs!

The faststart images have performed the installation process already which probably will involves some unpacking, hence the bigger image.

However, they start significantly faster which is key in integration tests.

Would this non fast start only be used in your own tests or also as default in the shipped lib?

if the latter, I would suggest to keep the slim fast start.

The default image tag is 21.3.0-slim-faststart. I believe @0xced suggested the *-slim tags in case we want to keep all Oracle tests within the same project and run them on a single runner. Anyway, we still use *-slim-faststart and recommend that developers override the default image and pin their preferred version.

[HofmeisterAn]

Thank you for the PR again. It looks good. I just have two minor questions. Let me know what you think and if we need to address them.

[HofmeisterAn]

Thanks ✌️.