feat: add build to life cycle hooks #2653
Draft
+247
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stevenh
force-pushed
the
feat/build-lifecycle
branch
2 times, most recently
from
b68d4a3
to
6384301
Compare
Add pre and post build life cycle hooks so the user can see when an image build is occurring and what it's tag is. Refactor combineContainerHooks to support additional fields automatically. Reduce overhead of hook error handling by starting with an nil error slice and use append to allocate only if needed, in other words assume the happy path by default hence minimising allocations. Minimise code used in hook handling by using helper methods. Eliminate unused / shadowed parameters from defaultPreCreateHook. GetRepo and GetTag now return a consistent UUID if the Repo or Tag field aren't set by setting their values. This was needed to enable the output of the image we're going to build in the log.
stevenh
force-pushed
the
feat/build-lifecycle
branch
from
6384301
to
90afc8b
Compare
|
For this one, we have docs documenting the lifecycle hooks here: https://golang.testcontainers.org/features/creating_container/#lifecycle-hooks could you also update that? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pre and post build life cycle hooks so the user can see when an image build is occurring and what it's tag is.
Refactor combineContainerHooks to support additional fields automatically.
Reduce overhead of hook error handling by starting with an nil error slice and use append to allocate only if needed, in other words assume the happy path by default hence minimising allocations.
Minimise code used in hook handling by using helper methods.
Eliminate unused / shadowed parameters from defaultPreCreateHook.
GetRepo and GetTag now return a consistent UUID if the Repo or Tag field aren't set by setting their values. This was needed to enable the output of the image we're going to build in the log.