Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add build to life cycle hooks #2653

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add build to life cycle hooks #2653

wants to merge 1 commit into from
+247 −81

Commits on Jul 17, 2024

  1. feat: add build to life cycle hooks 

    Add pre and post build life cycle hooks so the user can see when an image
build is occurring and what it's tag is.

Refactor combineContainerHooks to support additional fields automatically.

Reduce overhead of hook error handling by starting with an nil error
slice and use append to allocate only if needed, in other words assume
the happy path by default hence minimising allocations.

Minimise code used in hook handling by using helper methods.

Eliminate unused / shadowed parameters from defaultPreCreateHook.

GetRepo and GetTag now return a consistent UUID if the Repo or Tag field
aren't set by setting their values. This was needed to enable the output
of the image we're going to build in the log.
    @stevenh
    stevenh committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    90afc8b View commit details
    Browse the repository at this point in the history