Multiple exceptions when count does not match the number of elements - fixes issue #735#736
Open
doomlaur wants to merge 5 commits intotfussell:masterfrom
Open
Multiple exceptions when count does not match the number of elements - fixes issue #735#736doomlaur wants to merge 5 commits intotfussell:masterfrom
count does not match the number of elements - fixes issue #735#736doomlaur wants to merge 5 commits intotfussell:masterfrom
Conversation
This was referenced May 22, 2024
… attribute. Added a unit tests with multiple wrong "count" values. Fixed a related exception when loading the shared string table with the wrong "uniqueCount".
…s only if THROW_ON_INVALID_XML is defined).
…tions like std::vector::reserve (or for other containers), creating simpler code. This now also ensures that memory is pre-allocated even if XML attributes like "count" specify an extreme number of elements (in which case no memory was previously allocated at all anymore).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #735