Behemoth V2 - Complete Rework#18481
Conversation
|
I hope it's bigger defender 🥹🙏 |
Lumipharon
left a comment
There was a problem hiding this comment.
First pass. Lots more but a whole bunch of this stuff is just repeated minor issues for you to sort out
|
|
||
| /obj/effect/temp_visual/behemoth/stomp/east/Initialize(mapload, direction) | ||
| /* to do: need damage icons |
There was a problem hiding this comment.
Yeah, I do need sprites for Earth Pillar. I'll see if I can get those sometime soon.
Lumipharon
left a comment
There was a problem hiding this comment.
some review on the updates
|
|
||
| /// Applies various effects to a selection of tiles in front of the user. | ||
| /datum/action/ability/activable/xeno/landslide/proc/on_move(datum/source, atom/old_loc, movement_dir, forced, list/old_locs) | ||
| /datum/action/ability/activable/xeno/landslide/proc/user_move(datum/source, atom/old_loc, movement_dir, forced, list/old_locs) |
There was a problem hiding this comment.
its not a big deal but I meant something like /on_owner_move() or something so its just very clear exactly what is happening here and why.
The action isn't moving, the proc isn't moving the user either, its doing something because the owner moved.
There was a problem hiding this comment.
I've changed this and the pre move proc to owner_moved and owner_pre_move respectively.
| // *************************************** | ||
| // *********** Earth Pillar | ||
| // *************************************** | ||
| #define isearthpillar(A) (istype(A, /obj/structure/xeno/earth_pillar)) // So that we don't need to repeat the type path. |
There was a problem hiding this comment.
this should be in the file with the other isx defines
There was a problem hiding this comment.
Done in next commit.
|
|
Played it and this is a pretty awesome rework. My only real issue was how long the cooldown on getting a new rock is, but its a pretty fair balance decision still with how strong it is here. |
|
As long as they can still eat rocks im happy |
|
fix conflict for metge |
I'll discuss this with Lumi to see what they think.
This is an issue with most forms of throws (such as Runner and Hunter's pounces, Defender's charge, and so on). The xeno will just go under the tank, which can result in awkward scenarios like these. I'll see what I can do to fix it for Behemoth, at least.
More walance stuff, so I'll also discuss it with Lumi.
not anymore it isn't >:) |
List of changes since last test mergeStat changes
Earth Riser
Earth Pillars
Geocrush
Bug fixes
Code stuff
|
HI MAINTAINERS PLEASE TEST MERGE THIS DO NOT MERGE IT I MADE BIG CHANGES THAT NEED TESTINGthank you |
Lumipharon
left a comment
There was a problem hiding this comment.
Most of this is OK at a quick review, but some of these geocrush interactions are pretty cursed.
About The Pull Request
Check out the design document here.
⠀
Completely reworks Behemoth from the ground up. Its role in a hive has been redesigned, and its abilities have been changed to better accommodate for what is intended and expected of it. Visual and sound effects have also been changed here and there in lieu of changes and additions. Lastly, this PR also refactors most of the coding related to this caste.
To do:
Why It's Good For The Game
Behemoth has been in a weird spot ever since its introduction into the game. It tried to do various things at once, and it failed to compete with marines and most other castes. This PR aims to properly define its identity and reflect that in its kit, while also making it an attractive pick for our players.
Credits
Changelog
🆑 Lewdcifer
add: Behemoth has been COMPLETELY reworked from the ground up.
spellcheck: The changelog only offers a very brief overview, so if you're interested in specifics, refer to the pull request.
add: Added a new ability, Seize. Fast movement option that requires Earth Pillars to function.
add: Added a new ability, Geocrush. Heavy melee damage.
del: Rolling ability removed.
del: Seismic Fracture removed.
balance: Redesigned Earth Riser, as well as Earth Pillars, to be faster, resilient, and versatile, but more limited in access, damage, and range.
balance: You can now climb and jump over Earth Pillars.
balance: Landslide redesigned to be much faster in execution, similarly to its now deprecated Primordial variant, at the expense of damage and reach.
balance: Primal Wrath, the Behemoth's primordial ability, has been completely redesigned. Instead of upgrading all of your abilities, it will now restore all damage taken in a time window, while providing a few seconds of invulnerability, in exchange for a stacking temporary debuff.
balance: Allied xenos can no longer ride the Behemoth.
add: Added various statistic trackers for several Behemoth actions.
soundadd: Added a few new sounds for Earth Pillars, Landslide, and Geocrush.
sounddel: Removed unused sounds related to Behemoth.
imageadd: Added some new sprites for Earth Pillars, Landslide, and Geocrush. Also reorganized Behemoth's stuff.
imagedel: Removed unused sprites related to Behemoth.
fix: Squashed some bugs and fixed some glitches or unintended behavior related to Behemoth.
refactor: Refactored most, if not all, coding related to Behemoth.
/:cl: