A choice is picked randomly if there are no votes, can_start map blacklist removed#18559
Closed
mudzbe wants to merge 3 commits intotgstation:masterfrom
Closed
A choice is picked randomly if there are no votes, can_start map blacklist removed#18559mudzbe wants to merge 3 commits intotgstation:masterfrom
mudzbe wants to merge 3 commits intotgstation:masterfrom
Conversation
github-actions
bot
added
Removal
Contributor
|
The whitelist has priority over the black list, so this shouldn't be needed unless vote code has been changed? |
mudzbe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
The blacklist check was to fix an issue where when no one voted the old groundmap was retained, this meant if fort phobos was the current map and crash maps were played the game would break. Fort phobos was blacklist is inherited from datum/game_mode and stoped campaign from starting normally. Replaces the can_start blacklist check with a choice randomly being picked.
Why It's Good For The Game
It's important
Changelog
🆑
remove: Can_start blacklist check removed
fix: Campaign can start again
/:cl: