vote and restart improvements#18728
Open
Lumipharon wants to merge 7 commits into
Open
Conversation
github-actions
Bot
added
Refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Test this shit before merge
Refactored how gamemode/map votes are done at the end of the round, and how the server restarts.
Added a visible restart timer so people can see exactly when the server is going to restart (or if its delayed).
Also made the vote system announce automatic vote results (i.e. where there was only 1 valid outcome) so players actually see what's going on.
For admins:
We now have 3 distinct server verbs.
Cancel restart - cancels the restart timer.
Set restart timer - lets you set a custom restart time (overriding an existing one if it exists), max of 10 minutes.
Delay Round end - Toggles on and off. Stops server autorestart timer from triggering, and cancels any existing timer.
Each time a gamemode vote is done in the post game, map votes will be autotriggered afterwards. This includes admin forced votes. The reboot timer is updated when votes are done - this means lifting the round end delay will set a reboot timer automatically once the next vote is finished, but also means the delay isn't drawn out if certain votes aren't needed (i.e. hvh modes where there's only one choice etc).
Why It's Good For The Game
Better visibility, hopefully less prone to shitting itself.
Changelog
🆑
qol: Added visibility for when the server is going to restart
refactor: refactored some code relating to end of round votes and restarts
admin: Added more server verbs relating to server restarts
/:cl: