Barricade refactor#18760
Open
Lumipharon wants to merge 12 commits into
Open
Conversation
github-actions
Bot
added
Refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Probably TM first. I've tested it and it seems to all work fine, but this touches a lot of stuff.
Refactors and reorganises barricade code as it was a nightmare of spaghetti and duplicated code.
Fixes #18745
All construction stuff now actually uses the construction skill instead of some of it using engineering.
Fixed lots of small inconsistancies/minor bugs.
Autodoc for days
Way more generic code (i.e. less walls of texts copy pasted between normal and folding cades)
Lots of stuff uses flags instead of 20 vars.
I can probably consolidate some stuff down even further, but this is a good start at least.
Why It's Good For The Game
Removes a huge amount of duplicate code and reorganised it to be actually somewhat readable and maintainable.
Changelog
🆑
fix: fixed a plasteel duplication exploit
refactor: refactored barricade code
/:cl: