Better explosion logging#18763
Open
Lumipharon wants to merge 6 commits into
Open
Conversation
github-actions
Bot
added
Administration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Explosion logging is now actually useful.
It now tracks the source of the explosion (i.e. what actually blew up) and the mob that caused it.
This display in the attack logs, including the actual chat attack logs, so admins can see what's going on if needed.
Not all explosions will have the mob be trackable due to a variety of reasons, but most common causes are, namely:
Why It's Good For The Game
Currently this is fucking awful for admins to try trace down, this should make it super easy to do so in the majority of cases.
Changelog
🆑
admin: Greatly improved explosion logging
/:cl: