fix(workflows): deterministic notifier task ordering - #328
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes notifier provider iteration deterministic in Thand workflow task notification paths to avoid Temporal replay nondeterminism caused by randomized Go map iteration.
Changes:
- Collect and sort notifier provider map keys before building notification tasks.
- Apply deterministic provider ordering consistently across authorize, revoke, approvals (including rejection), and form notification flows.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/workflows/tasks/providers/thand/authorize.go | Sorts notifier provider keys before building authorization notification tasks. |
| internal/workflows/tasks/providers/thand/revoke.go | Sorts notifier provider keys before building revocation notification tasks. |
| internal/workflows/tasks/providers/thand/approvals.go | Sorts notifier provider keys for approval notifications and rejection notifications. |
| internal/workflows/tasks/providers/thand/form.go | Sorts notifier provider keys before building form notification tasks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Go map iteration order is randomized. These notification tasks are later scheduled via workflow goroutines, so non-deterministic iteration can reorder scheduled activities between runs.
Changes
Validation