Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execution: Add support for double_exponential_smoothing function #517

Merged
merged 9 commits into from
Feb 18, 2025
Merged

execution: Add support for double_exponential_smoothing function #517

merged 9 commits into from
Feb 18, 2025

Conversation

subhramit
Copy link
Contributor

Closes #138

Added support for double_exponential_smoothing function, as discussed in #138 (comment).

@subhramit
Copy link
Contributor Author

subhramit commented Feb 11, 2025 •
edited
Loading

Hi everyone, this is my first contribution here - with an intent to get myself accustomed to the codebase.
I could not find any contributing guidelines in this repository, so went through the coding style guidelines in the main Thanos project and tried to stick to them - although it's highly possible I may have missed something, so please do point out.

I used GoLand to execute tests locally.
I have some questions/comments, which I will leave by marking corresponding code below.

@subhramit subhramit force-pushed the add-double-exp-smoothing branch from 345a96e to 550fc09 Compare February 12, 2025 09:58
@subhramit
Reset commit - add
2bb68fb 
Signed-off-by: Subhramit Basu Bhowmick <[email protected]>
@subhramit subhramit force-pushed the add-double-exp-smoothing branch from 6509aa5 to 2bb68fb Compare February 12, 2025 12:35
@subhramit
Fix failing workflows
cf527a7 
Signed-off-by: Subhramit Basu Bhowmick <[email protected]>
@subhramit
Copy link
Contributor Author

@saswatamcode lint and docs workflows were failing, I fixed them with make docs and make format. Could you give the workflow approval again to check?

@subhramit
Apply linter suggestion
0b95b41 
Signed-off-by: Subhramit Basu Bhowmick <[email protected]>
@subhramit
Copy link
Contributor Author

@saswatamcode Have implemented your suggestions.

@subhramit subhramit mentioned this pull request Feb 15, 2025
Closed
47 tasks
@fpetkovski
Copy link
Collaborator

Fuzzing usually fails due to timeouts, let me restart it

saswatamcode
saswatamcode approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@subhramit
Copy link
Contributor Author

Fuzzing usually fails due to timeouts, let me restart it

Yep, green now!

@saswatamcode saswatamcode merged commit 9405e06 into thanos-io:main Feb 18, 2025
7 checks passed
@subhramit subhramit deleted the add-double-exp-smoothing branch February 18, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpetkovski fpetkovski fpetkovski approved these changes

@saswatamcode saswatamcode saswatamcode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for all functions
3 participants
@subhramit @fpetkovski @saswatamcode