feat: support thanos-style storage config#4
Open
verejoel wants to merge 2 commits intothanos-io:mainfrom
Open
Conversation
Signed-off-by: Joel Verezhak <j.verezhak@gmail.com>
verejoel
force-pushed
the
feature/thanos-style-config
branch
from
7120e66 to
72c4fa9
Compare
Contributor
Author
|
@GiedriusS ready for review! |
MichaHoffmann
approved these changes
Jul 8, 2025
GiedriusS
reviewed
Jul 8, 2025
Signed-off-by: Joel Verezhak <46783161+verejoel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @MichaHoffmann, this removes the old-style flags for configuring object storage and uses the same style of arguments as Thanos.