Integrate Renovate Update Dev Deps and Fix the resulting Linting Errors.#1149
Integrate Renovate Update Dev Deps and Fix the resulting Linting Errors.#1149FSG-Cat wants to merge 8 commits into
Conversation
|
|
GHCR image refs for this PR:
This comment is generated from PR metadata only. It does not checkout or run PR code and is generated in a static manner |
FSG-Cat
force-pushed
the
FSG-Cat/resolve-dev-deps
branch
from
a8c67a1 to
c3d4d10
Compare
Draupnir\packages\mps-interface-adaptor\src\MPSInterfaceAdaptor\MPSMatrixInterfaceAdaptor.ts 42:10 error 'Result' is defined but never used @typescript-eslint/no-unused-vars Draupnir\packages\mps-interface-adaptor\src\MPSInterfaceAdaptor\MPSMatrixInterfaceAdaptor.ts 42:10 error 'Result' is defined but never used @typescript-eslint/no-unused-vars Draupnir\apps\draupnir\src\protections\ProtectedRoomsSetRenderers.tsx 20:10 error 'Result' is defined but never used @typescript-eslint/no-unused-vars
\Draupnir\packages\interface-manager\src\Command\CommandTable.ts 19:3 error 'Presentation' is defined but never used @typescript-eslint/no-unused-vars
Draupnir\apps\draupnir\test\appservice\integration\managedBootstrapStartTest.ts 5:10 error 'StringUserID' is defined but never used @typescript-eslint/no-unused-vars
Draupnir\packages\matrix-protection-suite\src\Protection\ProtectionHandles.test.ts 10:10 error 'PowerLevelsEventContent' is defined but never used @typescript-eslint/no-unused-vars
Draupnir\apps\draupnir\src\webapis\SynapseHTTPAntispam\SpamCheckEndpointPluginManager.ts 43:36 error Promise returned in function argument where a void return was expected @typescript-eslint/no-misused-promises Trying to fix this naively will lead to a cascade of issues but this is ultimately a fix via splitting into blocking and non blocking.
FSG-Cat
force-pushed
the
FSG-Cat/resolve-dev-deps
branch
from
c3d4d10 to
f674cfb
Compare
| public unregisterHandle( | ||
| handle: BlockingCallback<CBArguments> | NonBlockingCallback<CBArguments> | ||
| public unregisterBlockingHandle(handle: BlockingCallback<CBArguments>): void { | ||
| this.blockingHandles.delete(handle); | ||
| } | ||
|
|
||
| public unregisterNonBlockingHandle( | ||
| handle: NonBlockingCallback<CBArguments> | ||
| ): void { | ||
| this.blockingHandles.delete(handle as BlockingCallback<CBArguments>); | ||
| this.nonBlockingHandles.delete(handle as NonBlockingCallback<CBArguments>); | ||
| this.nonBlockingHandles.delete(handle); | ||
| } |
There was a problem hiding this comment.
Rules changed and the original way this file was written violates lint rules. I only have the exact lint error from after the fix was run.
| @@ -32,221 +32,213 @@ describe("Test: The redaction command", function () { | |||
| this.moderator?.stop(); | |||
| }); | |||
There was a problem hiding this comment.
What is going on in this file? what did you change and why? It's not really possible to tell from the diff mew
| const previewResult = ( | ||
| await draupnir.sendTextCommand( | ||
| draupnir.clientUserID, | ||
| `!draupnir unban ${falsePositiveUserID}` |
There was a problem hiding this comment.
same in this file, it is impossible to tell what is happening, possibly due to also a prettier version bump mixed in with other changes? I can't tell mew
|
maybe changes to prettier need to be isolated in the renovate config too mew |
2 participants
Its known that this PR does not lint cleanly yet its just Cat is not confident about how to Fix the last linting error so Cat decided time to push this if its time for collaboration to fix that last error.
This PR is derived from a slightly earlier version of #664 and a PR like this was required due to the whole fucking slew of linting errors.