Integrate Renovate Update Dev Deps and Fix the resulting Linting Errors.

apps/draupnir/src/appservice/AppServiceDraupnirManager.ts

@@ -285,7 +285,7 @@ export class AppServiceDraupnirManager {
         local_part: mjolnirLocalPart,
         owner: requestingUserID,
         management_room: managementRoom.ok.toRoomIDOrAlias(),
-      } as MjolnirRecord;
+      };
       await this.dataStore.store(record);
       return Ok(record);
     } else {

apps/draupnir/src/commands/ProtectionsCommands.tsx

@@ -487,7 +487,7 @@ export const DraupnirProtectionsConfigResetCommand = describeCommand({
     const newSettings =
       protectionDescription.protectionSettings.getDefaultConfig();
     return await draupnir.protectedRoomsSet.protections.changeProtectionSettings(
-      protectionDescription as unknown as ProtectionDescription,
+      protectionDescription,
       draupnir.protectedRoomsSet,
       draupnir,
       newSettings
@@ -517,7 +517,7 @@ export const DraupnirProtectionsCapabilityResetCommand = describeCommand({
       );
     }
     return await draupnir.protectedRoomsSet.protections.changeCapabilityProviderSet(
-      protectionDescription as unknown as ProtectionDescription,
+      protectionDescription,
       draupnir.protectedRoomsSet,
       draupnir,
       protectionDescription.defaultCapabilities

apps/draupnir/src/config.ts

@@ -592,7 +592,7 @@ export function getUnknownPropertiesHelper(
     } else {
       const unknownSubProperties = getUnknownPropertiesHelper(
         config[key],
-        defaultConfig[key] as Record<string, unknown>,
+        defaultConfig[key],
         [...currentPathProperties, key]
       );
       unknownProperties.push(...unknownSubProperties);
@@ -609,11 +609,7 @@ export function getUnknownConfigPropertyPaths(config: unknown): string[] {
   if (typeof config !== "object" || config === null) {
     return [];
   }
-  return getUnknownPropertiesHelper(
-    config,
-    defaultConfig as unknown as Record<string, unknown>,
-    []
-  );
+  return getUnknownPropertiesHelper(config, defaultConfig, []);
 }
 
 /**

apps/draupnir/src/protections/BlockInvitationsOnServerProtection.tsx

@@ -112,7 +112,7 @@ export class SynapseHTTPUserMayInvite {
   }
 
   unregisterListeners(): void {
-    this.synapseHTTPAntispam.userMayInviteHandles.unregisterHandle(
+    this.synapseHTTPAntispam.userMayInviteHandles.unregisterBlockingHandle(
       this.synapseHTTPCallback
     );
   }

apps/draupnir/src/protections/MissingProtectionPermissions.tsx

@@ -20,7 +20,6 @@ import {
   DeadDocumentJSX,
   DocumentNode,
 } from "@the-draupnir-project/interface-manager";
-import { Result } from "@gnuxie/typescript-result";
 
 function renderPermissions(
   title: DocumentNode,
@@ -106,7 +105,7 @@ export function makeHandleMissingProtectionPermissions(
           {renderMissingProtectionsPermissions(roomID, protectionPermissions)}
         </root>,
         {}
-      ) as Promise<Result<undefined>>
+      )
     );
   };
 }

apps/draupnir/src/protections/ProtectedRoomsSetRenderers.tsx

@@ -17,7 +17,6 @@ import {
 import { StringRoomID } from "@the-draupnir-project/matrix-basic-types";
 import { sendMatrixEventsFromDeadDocument } from "@the-draupnir-project/mps-interface-adaptor";
 import { DeadDocumentJSX } from "@the-draupnir-project/interface-manager";
-import { Result } from "@gnuxie/typescript-result";
 
 // The callback that this is required for in MPS, is kinda silly and should
 // really be `void` and not `Promise<void>`. If it wanted to be `Promise<void>`,
@@ -41,6 +40,6 @@ export async function renderProtectionFailedToStart(
         <span>{error.message}</span>
       </root>,
       {}
-    ) as Promise<Result<void>>
+    )
   );
 }

apps/draupnir/src/protections/RoomTakedown/SynapseHTTPAntispamRoomExplorer.ts

@@ -88,13 +88,13 @@ export class SynapseHTTPAntispamRoomExplorer implements RoomExplorer {
   }.bind(this);
 
   unregisterListeners(): void {
-    this.synapseHTTPAntispam.checkEventForSpamHandles.unregisterHandle(
+    this.synapseHTTPAntispam.checkEventForSpamHandles.unregisterNonBlockingHandle(
       this.handleCheckEventForSpam
     );
-    this.synapseHTTPAntispam.userMayInviteHandles.unregisterHandle(
+    this.synapseHTTPAntispam.userMayInviteHandles.unregisterNonBlockingHandle(
       this.handleUserMayInvite
     );
-    this.synapseHTTPAntispam.userMayJoinRoomHandles.unregisterHandle(
+    this.synapseHTTPAntispam.userMayJoinRoomHandles.unregisterNonBlockingHandle(
       this.handleUserMayJoin
     );
     this.batcher.dispose();

apps/draupnir/src/protections/invitation/JoinRoomsOnInviteProtection.tsx

@@ -136,7 +136,7 @@ export class JoinRoomsOnInviteProtection
         this.draupnir.managementRoomID,
         renderUnknownInvite(),
         {}
-      ) as Promise<ActionResult<undefined>>
+      )
     );
   }
 

apps/draupnir/src/safemode/PersistentConfigEditor.ts

@@ -134,7 +134,7 @@ export class StandardPersistentConfigEditor implements PersistentConfigEditor {
     }
     relevantStatus.error = new ConfigParseError(
       "There was a problem when using a property in the configuration.",
-      relevantStatus.description as unknown as ConfigDescription,
+      relevantStatus.description,
       [cause.error],
       relevantStatus.data
     );

apps/draupnir/src/webapis/SynapseHTTPAntispam/SpamCheckEndpointPluginManager.ts

@@ -36,11 +36,14 @@ export class SpamCheckEndpointPluginManager<CBArguments extends unknown[]> {
     this.nonBlockingHandles.add(handle);
   }
 
-  public unregisterHandle(
-    handle: BlockingCallback<CBArguments> | NonBlockingCallback<CBArguments>
+  public unregisterBlockingHandle(handle: BlockingCallback<CBArguments>): void {
+    this.blockingHandles.delete(handle);
+  }
+
+  public unregisterNonBlockingHandle(
+    handle: NonBlockingCallback<CBArguments>
   ): void {
-    this.blockingHandles.delete(handle as BlockingCallback<CBArguments>);
-    this.nonBlockingHandles.delete(handle as NonBlockingCallback<CBArguments>);
+    this.nonBlockingHandles.delete(handle);
   }
 
   public unregisterListeners(): void {

apps/draupnir/test/appservice/integration/managedBootstrapStartTest.ts

@@ -2,7 +2,6 @@
 //
 // SPDX-License-Identifier: AFL-3.0
 
-import { StringUserID } from "@the-draupnir-project/matrix-basic-types";
 import { readTestConfig, setupHarnessWithConfig } from "../utils/harness";
 import { newTestUser } from "../../integration/clientHelper";
 import { MjolnirAppService } from "../../../src/appservice/AppService";
@@ -18,8 +17,7 @@ describe("Managed room bootstrap startup integration", function (this: Mocha.Sui
       ...(config as unknown as Record<string, unknown>),
     };
     testConfigRecord.adminRoom = undefined;
-    testConfigRecord.initialManager =
-      (await initialManager.getUserId()) as StringUserID;
+    testConfigRecord.initialManager = await initialManager.getUserId();
     const testConfig = testConfigRecord as typeof config;
 
     let appservice: MjolnirAppService | undefined;