fix(codex): install local plugin cache during setup#3066
Open
Retengart wants to merge 2 commits into
Open
Conversation
Contributor
Greptile SummaryThis PR updates Codex setup so the local plugin cache is installed during
Confidence Score: 5/5The changes are focused on Codex setup behavior and are covered by targeted installer and runtime tests. No issues were identified in the reviewed changes, and the described verification includes relevant non-interactive install, integration, typecheck, and build coverage.
What T-Rex did
Reviews (2): Last reviewed commit: "fix(codex): fail when plugin cache insta..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex plugin add claude-mem@claude-mem-localafter registering the local marketplace.install-versioninto the bundled marketplace plugin root before Codex installs from itRoot cause
On current Codex CLI,
codex plugin marketplace upgrade claude-mem-localis only valid for Git marketplaces. For a local marketplace it fails with:The installer ran that command best-effort, so installs could still report Codex marketplace registration success while
codex plugin listshowedclaude-mem@claude-mem-localasnot installedand no active Codex plugin cache existed.A second related gap is that Codex installs by copying from the bundled marketplace plugin root. That root did not receive
.install-version, so a freshly installed Codex cache could inherit a missing marker and hit theruntime not yet set upSessionStart path even though runtime setup had completed elsewhere.Related older report: #2361.
Verification
codex plugin liststill showednot installeduntilcodex plugin add claude-mem@claude-mem-localwas run.codex plugin listshowsinstalled, enabled; worker readiness returns ready; direct Codex hook replay returns accepted JSON forSessionStart,PreToolUse, andPostToolUsewith nosuppressOutputon tool hooks.bun test tests/install-non-tty.test.ts tests/integration/codex-cli-installer.test.ts tests/setup-runtime.test.ts tests/services/integrations/spawn-contract-windows.test.tsnpm run typecheck:rootnpm run build