Fixes #38267 - rake ovirt:drop #10469

stejskalleos · 2025-03-05T10:59:52Z

Rake task for removal of Ovirt compute resources and its data

Disassociate all hosts from the CR
Update host groups
Remove Compute resource & its profiles

Note:

The code removal will follow in the upcoming PR
The rake task should work with removed Ovirt code
This rake task is going to be cherry-picked to earlier versions, so users can run it before upgrading their instances
It will be a migration as well.

stejskalleos · 2025-03-05T14:59:14Z

@Lennonka text review please. This should also be documented in the upgrading workflow. The versions to chery-pick have not been decided yet.

chris1984

@stejskalleos want me to test this?

ekohl

Without looking at the exact code I'd expect an RFC for such a user visible change as well as deprecation notices in the release notes.

The code removal will follow in the upcoming PR

This will also need packaging changes since we have a foreman-ovirt subpackage.

stejskalleos · 2025-03-06T07:27:47Z

Without looking at the exact code I'd expect an RFC for such a user visible change as well as deprecation notices in the release notes.

Good point, I'll create an RFC.

I was under the impression that the deprecation was announced, but looking at the documentation code, it seems like it was deprecated only for Satellite.
@Lennonka together with this PR we should announce deprecation of the Ovirt for the upcoming upstream version
The Ovirt code can then be removed in the next version.

This will also need packaging changes since we have a foreman-ovirt subpackage.

Yop. Packaging and installer PRs will be in the scope.

stejskalleos · 2025-03-06T07:34:34Z

@chris1984 QE's will be testing it before the merge, but if you have time, It will be good to have it tested by dev as well

ekohl

On the rake task I'm wondering if we should somehow generalize it so it could be used for more compute resources. I have some vague recollection about users wanting to disassociate VMs from the UI, but I think that was also from before you could avoid deleting a VM when you deleted the Foreman host.

ekohl · 2025-03-06T11:17:25Z

lib/tasks/ovirt.rake

+  end
+
+  def ask_user
+    puts "!!! WARNING !!! This operation is irreversible."


Technically you can link them back up so I'm not sure it's really that irreversible. Just quite a bit of work.

lib/tasks/ovirt.rake

Lennonka

Just a couple of nitpicks. + I agree with Ewoud

lib/tasks/ovirt.rake

ekohl · 2025-03-06T17:30:41Z

@ColeHiggins2 for your visibility: this is something to keep track of for Foreman 3.14.

ShimShtein · 2025-03-09T14:56:11Z

@stejskalleos I think you also need to remove compute_attributes from the relevant compute profiles.

stejskalleos · 2025-03-11T08:01:10Z

@ekohl @Lennonka Log messages fixed

@ShimShtein Compute Attrs should be removed together with the compute resource, see https://github.com/theforeman/foreman/blob/develop/app/models/compute_resource.rb#L28

lib/tasks/ovirt.rake

stejskalleos · 2025-03-13T11:16:21Z

Support for OVIRT_ASSUME_YES
Listing affected compute resources in the warning
RHEV -> RHV

stejskalleos · 2025-03-17T07:58:32Z

Not sure why the CI is failing but the PR is ready for re-review. cc @chris1984 @ekohl

stejskalleos · 2025-03-18T09:07:18Z

And it's all green! @nofaralfasi can you review please?

ekohl · 2025-03-18T14:21:51Z

This rake task is going to be cherry-picked to earlier versions, so users can run it before upgrading their instances

To be explicit: you want this in 3.14?

nofaralfasi · 2025-03-18T14:37:40Z

On the rake task I'm wondering if we should somehow generalize it so it could be used for more compute resources.

Why would a user want to remove all compute resources of a provider while keeping the hosts? Is that a valid use case?
In general, I agree that we should make it more flexible. However, perhaps we should consider a different RFC, like one for completely removing a compute resource - which would also delete all associated hosts and hostgroups.
Alternatively, we could add an option that prompts the user to decide if they want to remove the hosts and hostgroups as well (maybe something we should consider for this PR as well).

ekohl · 2025-03-18T14:49:19Z

Why would a user want to remove all compute resources of a provider while keeping the hosts? Is that a valid use case?

Depends on their migration plan. This way they don't need to migrate their hosts, but they can no longer do things like power management or delete the actual VM. IMHO that's valid. It may also be that they will bulk migrate them to some other platform and don't want to import them again. Instead, they can (if Foreman supports the compute resource) link them back up to the new CR.

In general, I agree that we should make it more flexible. However, perhaps we should consider a different RFC, like one for completely removing a compute resource - which would also delete all associated hosts and hostgroups.

I think that's dangerous. Deleting hosts will terrify any sysadmin. Worst case you wipe out an entire infrastructure. Hostgroups may also be mixed.

Alternatively, we could add an option that prompts the user to decide if they want to remove the hosts and hostgroups as well (maybe something we should consider for this PR as well).

A noop mode is generally speaking a good idea, listing what would be affected.

stejskalleos · 2025-03-19T07:53:18Z

To be explicit: you want this in 3.14?

It would be nice to have it there, as it gives users more time for migration and preparation. But it's not a requirement.

like one for completely removing a compute resource

I want to leave that up to the user. As @ekohl said, removing hosts and host groups might be terrifying.

A noop mode is generally speaking a good idea, listing what would be affected.

I'll add it; that's a good idea.

stejskalleos · 2025-03-19T08:42:17Z

Updated:

Added pretend mode for listing affected resources.
Using User.as_anonymous_admin instead of .unscoped
Improved description and help message.

stejskalleos · 2025-03-24T09:25:48Z

And it's 🍏
@nofaralfasi review please
@amolpati30 ready for QE

amolpati30 · 2025-03-24T16:13:29Z

@stejskalleos
Tested with this patch, and it successfully removes the Compute Resource, Compute Profile, and RHV from the Host Group. However, testing for the Host was not possible as the manifest is not working on stream.

stejskalleos · 2025-03-27T06:45:14Z

@nofaralfasi any comments, or can we merge?

nofaralfasi

Another suggestion: You have multiple methods that print a message and exit. Why not refactor them into a single method that takes a message and an exit status as arguments?

lib/tasks/ovirt.rake

stejskalleos · 2025-03-28T08:48:51Z

Another suggestion: You have multiple methods that print a message and exit. Why not refactor them into a single method that takes a message and an exit status as arguments?

Most of them have multi-line output, and storing that output in a variable and then passing it to the method is not very readable, IMO. So, in this case, I chose readability over DRY.

nofaralfasi

I left all my notes and let Leos decide which ones to address. Other than that, the code looks good to me, but I didn’t test it.

Rake task for removal of Ovirt compute resources and its data - Disassociate all hosts from the CR - Update host groups - Remove Compute resource & its profiles

stejskalleos · 2025-03-31T06:26:19Z

@nofaralfasi Sorry, my bad, I accidentally missed the prompt_user_confirmation rename. Now it should be 1:1 with your comments.

amolpati30 · 2025-04-01T10:56:57Z

@stejskalleos
I have tested and LGTM.

pr-processor bot added the Not yet reviewed label Mar 5, 2025

stejskalleos assigned ShimShtein and nofaralfasi Mar 5, 2025

chris1984 reviewed Mar 5, 2025

View reviewed changes

pr-processor bot removed the Not yet reviewed label Mar 5, 2025

ekohl reviewed Mar 5, 2025

View reviewed changes

ekohl reviewed Mar 6, 2025

View reviewed changes

Lennonka suggested changes Mar 6, 2025

View reviewed changes

lib/tasks/ovirt.rake Outdated Show resolved Hide resolved

lib/tasks/ovirt.rake Outdated Show resolved Hide resolved

lib/tasks/ovirt.rake Outdated Show resolved Hide resolved

pr-processor bot added the Waiting on contributor label Mar 6, 2025

stejskalleos force-pushed the ls/ovirt-rake branch from 31a6711 to b0e3699 Compare March 11, 2025 07:59

pr-processor bot added Needs re-review and removed Waiting on contributor labels Mar 11, 2025

stejskalleos mentioned this pull request Mar 11, 2025

Deprecate oVirt theforeman/foreman-documentation#3724

Closed

ekohl reviewed Mar 11, 2025

View reviewed changes

lib/tasks/ovirt.rake Outdated Show resolved Hide resolved

pr-processor bot removed the Needs re-review label Mar 11, 2025

evgeni reviewed Mar 11, 2025

View reviewed changes

lib/tasks/ovirt.rake Outdated Show resolved Hide resolved

evgeni reviewed Mar 11, 2025

View reviewed changes

lib/tasks/ovirt.rake Outdated Show resolved Hide resolved

stejskalleos force-pushed the ls/ovirt-rake branch from b0e3699 to 9230fd7 Compare March 13, 2025 11:15

stejskalleos force-pushed the ls/ovirt-rake branch from 9230fd7 to bb66d18 Compare March 13, 2025 11:16

stejskalleos mentioned this pull request Mar 13, 2025

Remove oVirt & RHV code #10479

Merged

9 tasks

stejskalleos force-pushed the ls/ovirt-rake branch from bb66d18 to 7e1818d Compare March 17, 2025 07:19

stejskalleos requested a review from nofaralfasi March 18, 2025 08:35

stejskalleos force-pushed the ls/ovirt-rake branch from 7e1818d to 0ea0efd Compare March 19, 2025 08:40

stejskalleos force-pushed the ls/ovirt-rake branch from 0ea0efd to f3989b4 Compare March 24, 2025 08:16

nofaralfasi requested changes Mar 27, 2025

View reviewed changes

pr-processor bot added the Waiting on contributor label Mar 27, 2025

stejskalleos force-pushed the ls/ovirt-rake branch from f3989b4 to 5823f82 Compare March 28, 2025 08:58

pr-processor bot added Needs re-review and removed Waiting on contributor Needs re-review labels Mar 28, 2025

nofaralfasi previously approved these changes Mar 30, 2025

View reviewed changes

Fixes #38267 - rake ovirt:drop

f74dc3b

Rake task for removal of Ovirt compute resources and its data - Disassociate all hosts from the CR - Update host groups - Remove Compute resource & its profiles

stejskalleos dismissed nofaralfasi’s stale review via f74dc3b March 31, 2025 06:25

stejskalleos force-pushed the ls/ovirt-rake branch from 5823f82 to f74dc3b Compare March 31, 2025 06:25

nofaralfasi approved these changes Mar 31, 2025

View reviewed changes

stejskalleos merged commit cfc8b1d into theforeman:develop Apr 1, 2025
28 of 31 checks passed

stejskalleos mentioned this pull request Apr 14, 2025

Fixes #38266 - Migration for oVirt resources #10521

Merged

Fixes #38267 - rake ovirt:drop #10469

Fixes #38267 - rake ovirt:drop #10469

Uh oh!

Conversation

stejskalleos commented Mar 5, 2025

Uh oh!

stejskalleos commented Mar 5, 2025

Uh oh!

chris1984 left a comment

Choose a reason for hiding this comment

Uh oh!

ekohl left a comment

Choose a reason for hiding this comment

Uh oh!

stejskalleos commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stejskalleos commented Mar 6, 2025

Uh oh!

ekohl left a comment

Choose a reason for hiding this comment

Uh oh!

ekohl Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lennonka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ekohl commented Mar 6, 2025

Uh oh!

ShimShtein commented Mar 9, 2025

Uh oh!

stejskalleos commented Mar 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stejskalleos commented Mar 13, 2025

Uh oh!

stejskalleos commented Mar 17, 2025

Uh oh!

stejskalleos commented Mar 18, 2025

Uh oh!

ekohl commented Mar 18, 2025

Uh oh!

nofaralfasi commented Mar 18, 2025

Uh oh!

ekohl commented Mar 18, 2025

Uh oh!

stejskalleos commented Mar 19, 2025

Uh oh!

stejskalleos commented Mar 19, 2025

Uh oh!

stejskalleos commented Mar 24, 2025

Uh oh!

amolpati30 commented Mar 24, 2025

Uh oh!

stejskalleos commented Mar 27, 2025

Uh oh!

nofaralfasi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stejskalleos commented Mar 28, 2025

Uh oh!

nofaralfasi left a comment

Choose a reason for hiding this comment

Uh oh!

stejskalleos commented Mar 6, 2025 •

edited

Loading