Fixes #39413 - Track and surface unrecognized Smart Proxy features#11017
Open
adamruzicka wants to merge 2 commits into
Open
Fixes #39413 - Track and surface unrecognized Smart Proxy features#11017adamruzicka wants to merge 2 commits into
adamruzicka wants to merge 2 commits into
Conversation
This was referenced Jun 10, 2026
adamruzicka
force-pushed
the
unknown-proxy-features
branch
from
d72629d to
5c8f26c
Compare
adamruzicka
changed the title
When a Smart Proxy reports features that Foreman doesn't recognize (e.g. a plugin installed on the proxy but not on the server), those features were silently dropped. Now they are persisted and surfaced to the user via the API, UI, and server logs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add h() escaping to index tooltip for defensive XSS protection - Use "Smart Proxy" consistently in UI terminology - Broaden user-facing messages to mention version mismatches and custom proxy extensions as possible causes, not just missing plugins - Use unrecognized_features instead of reply.keys for error message consistency - Add test for clearing unrecognized features on proxy re-save - Add unrecognized_features assertion to V1 API test path Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
adamruzicka
force-pushed
the
unknown-proxy-features
branch
from
8d2f259 to
b0a4740
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Smart Proxy reports features that Foreman doesn't recognize (e.g. a plugin installed on the proxy but not on the server), those features were silently dropped. Now they are persisted and surfaced to the user via the API, UI, and server logs.
A draft until all the other pieces are assembled
Index
Show
To be squashed before merging