Conversation
adamruzicka
left a comment
adamruzicka
left a comment
There was a problem hiding this comment.
In general it looks ok, but the french translations seem somewhat wonky.
| ], | ||
| "Run hosts job:": [ | ||
| "" | ||
| "Exécuter la tâche des hôtes :" |
There was a problem hiding this comment.
Huh, does french really dictate spaces in front of colons?
| ], | ||
| "Open all failed runs on this page (%s)": [ | ||
| "" | ||
| "Ouvrir toutes les exécutions ayant échoué sur cette page (%s )" |
There was a problem hiding this comment.
Huh, does french really dictate spaces in front of closing parentheses?
There was a problem hiding this comment.
Seems like no, at least according to AI.
| "The number of failed invocations is:": [ | ||
| "" | ||
| "Le nombre des invocations est :" |
There was a problem hiding this comment.
This doesn't sound right?
There was a problem hiding this comment.
There is also missing negation in the translation
There was a problem hiding this comment.
Yes, that's what I meant
There was a problem hiding this comment.
I reached out to a non-technical, French-speaking individual, and they recommended using the following translation:
Le nombre d’invocations échouées est
@adamlazik1 I fixed all three manually in Transifex. It appears to be a human error. EDIT: Please try pulling strings again; it should propagate. |
adamlazik1
force-pushed
the
update-translations
branch
from
f7f2d72 to
3f45cb2
Compare
|
Thanks @adamruzicka @ogajduse ! I pulled the translations again. |
|
Hi, I would check it with someone who knows french better than me, but I think the spaces are correct. @ogajduse @adamlazik1 @adamruzicka |
adamlazik1
force-pushed
the
update-translations
branch
from
3f45cb2 to
66c7847
Compare
|
@adamruzicka @Lukshio The translations should now be fixed, please give this another look. |
adamruzicka
left a comment
adamruzicka
left a comment
There was a problem hiding this comment.
Ça a l'air assez français
| ], | ||
| "Unable to fetch CA public key": [ | ||
| "" | ||
| "Impossible de récupérer la clef publique CA" |
There was a problem hiding this comment.
Technically, in french is "autorité de certification" so instead of CA there should be AC. https://fr.wikipedia.org/wiki/Autorit%C3%A9_de_certification But I am not sure if we are using english version in this case.
There was a problem hiding this comment.
The wiki says AC or CA so I believe it's fine.
There was a problem hiding this comment.
These strings come directly from Transifex. Manually editing them is outside the scope of this PR, as we rely on the professional Red Hat translators for the content in fr, ko, zh_CN and de.
|
I believe the comments have been resolved, and there is ack in place, so I am merging. |
4 participants
No description provided.