Test refresh of internal CA doesn't break the bundle#671
Open
evgeni wants to merge 1 commit into
Open
Conversation
evgeni
force-pushed
the
ca-doesn-break-proxy
branch
2 times, most recently
from
July 17, 2026 08:53
e60702c to
6bb7f0d
Compare
8 tasks
evgeni
force-pushed
the
ca-doesn-break-proxy
branch
from
July 17, 2026 09:02
6bb7f0d to
94e634d
Compare
evgeni
commented
Jul 17, 2026
| - name: Generate certificates bundle on quadlet | ||
| run: | | ||
| ./foremanctl certificate-bundle proxy.example.com \ | ||
| --certificate-source=${{ matrix.certificate_source }} \ |
Member
Author
There was a problem hiding this comment.
This was what was making the tests pass before. Now we explicitly store only the source in L434.
evgeni
commented
Jul 17, 2026
evgeni
force-pushed
the
ca-doesn-break-proxy
branch
from
July 17, 2026 10:42
94e634d to
d3ca9c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
What are the changes introduced in this pull request?
How to test this pull request
Steps to reproduce:
Checklist