Skip to content

Test refresh of internal CA doesn't break the bundle #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evgeni wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −3
Open

Test refresh of internal CA doesn't break the bundle #671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,16 +420,20 @@ jobs:
--initial-admin-password=changeme \
--tuning development \
--add-feature foreman-proxy
- name: Remove old parameters.yaml
run: rm -f .var/lib/foremanctl/parameters.yaml
- name: Generate certificates bundle on quadlet
run: |
./foremanctl certificate-bundle proxy.example.com \
--certificate-source=${{ matrix.certificate_source }} \

@evgeni evgeni Jul 17, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was what was making the tests pass before. Now we explicitly store only the source in L434.

${{ matrix.certificate_source == 'custom_server' && '--certificate-server-certificate /root/custom-certificates/certs/proxy.example.com.crt --certificate-server-key /root/custom-certificates/private/proxy.example.com.key' || '' }}
- name: Refresh internal CA to ensure it doesn't break the bundle
if: matrix.certificate_source != 'custom_server'
run: |
./foremanctl deploy --certificate-ca-renew
- name: Fetch certificates bundle from quadlet
run: |
./forge fetch-bundle proxy.example.com
- name: Remove old parameters, but keep certificates_source for tests
run: |
echo "certificates_source: ${{ matrix.certificate_source }}" > .var/lib/foremanctl/parameters.yaml
- name: Deploy content proxy
run: |
./foremanctl deploy-proxy \
Expand Down