Update to gha-puppet v3 & voxpupuli-test 9.x

[ekohl]

No description provided.

[ekohl]

Wut?

Error: Facter: Error while resolving custom fact fact='rh_certificate', resolution='<anonymous>': break from proc-closure

[ekohl]

Error: Facter: Error while resolving custom fact fact='rh_certificate', resolution='<anonymous>': break from proc-closure

You're supposed to use next.

Now for the real failure: I think this is because a bash script has replaced the Ruby package so checks are failing.

@ofedoren I think that module effectively becomes obsolete, correct?

[ofedoren]

Now for the real failure: I think this is because a bash script has replaced the Ruby package so checks are failing.

Not sure how bash package would affect this... I mean, I tested with Ansible role and it worked. We probably need to adjust Puppet class somehow though?..

@ofedoren I think that module effectively becomes obsolete, correct?

You mean the entire puppet_foreman_scap_client? I wouldn't say so. We still need this to automatically install the package and generate the config file. Although, at some point, we'd need to explicitly install Bash version here instead of Ruby one.

[evgeni]

My understanding is that the new bash implementation is backwards compatible to the Ruby one, it uses the same config file, same executable name, everything. So unless this changes, this module is still usable (and required) as before. It "just" needs to know the right package name to become idempotent (again).