fix(ui): make drawer close button type button #1552

bigbyte-stuart · 2025-03-27T21:24:07Z

I have followed the Your First Code Contribution section of the Contributing guide

I have added a type="button" to the Drawer component's close button. If a button does not have a type, and is part of a form, then by default it is a submit button. See here. Therefore if the Drawer component forms part of a form flow, closing the drawer triggers the form's submit behaviour.

This also brings Flowbite React in line with vanilla Flowbite Drawer which uses type="button" on its close button.

Summary by CodeRabbit

Bug Fixes
- Improved the behavior of a button in the navigation panel header by explicitly defining its type, enhancing proper form interactions and accessibility.

changeset-bot · 2025-03-27T21:24:11Z

🦋 Changeset detected

Latest commit: 402e563

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
flowbite-react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-03-27T21:24:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
flowbite-react	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 28, 2025 3:53pm
flowbite-react-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 28, 2025 3:53pm

coderabbitai · 2025-03-27T21:24:17Z

Walkthrough

The changes involve adding the type="button" attribute to the <button> element in the DrawerHeader component. This specification enhances the button's behavior in forms and accessibility without modifying existing event handlers or the overall functionality of the component.

Changes

File(s)	Change Summary
packages/ui/src/components/Drawer/DrawerHeader.tsx	Added `type="button"` to the `<button>` element to explicitly specify its type.
.changeset/hungry-camels-make.md	Introduced a patch for the "flowbite-react" package to modify the close button type to "button."

Poem

In the code burrow, I hop with delight,
A small tweak shining oh so bright.
The button now wears its type with pride,
Ensuring form and function coincide.
Hoppy coding, from one rabbit to all!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4e6c43a and 402e563.

📒 Files selected for processing (1)

.changeset/hungry-camels-make.md (1 hunks)

🔇 Additional comments (2)

.changeset/hungry-camels-make.md (2)

1-3: Validate Changeset Header Format

The header correctly specifies the package ("flowbite-react") and designates the update as a patch. This adheres to the standard changeset format.

5-6: Confirm Clear, Concise Description

The description "make drawer close button type button" communicates the intent effectively. If future maintainers require additional context on why this change was made (i.e., preventing unintended form submissions), consider expanding this description in subsequent changesets.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

SutuSebastian

LGTM!

Please add a changeset by running bun changeset and select flowbite-react and patch version

vercel · 2025-03-27T22:23:26Z

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

bigbyte-stuart · 2025-03-27T22:34:47Z

LGTM!

Please add a changeset by running bun changeset and select flowbite-react and patch version

No problem, done! Not sure why the deployment is failing now.

bigbyte-stuart · 2025-03-28T14:26:55Z

@SutuSebastian Do you know how I can fix the deployment and get this merged?

SutuSebastian · 2025-03-28T15:40:12Z

very weird that it doesn't even notice the changeset 🤔 on top of the build failing

bigbyte-stuart · 2025-03-28T15:57:23Z

Empty commit to force build seems to have fixed it.

fix(ui): make drawer close button type button

4e6c43a

vercel bot deployed to Preview – flowbite-react-storybook March 27, 2025 21:25 View deployment

vercel bot deployed to Preview – flowbite-react March 27, 2025 21:26 View deployment

SutuSebastian reviewed Mar 27, 2025

View reviewed changes

chore: add changeset

efc7403

SutuSebastian approved these changes Mar 27, 2025

View reviewed changes

trigger build

402e563

vercel bot deployed to Preview – flowbite-react-storybook March 28, 2025 15:52 View deployment

vercel bot deployed to Preview – flowbite-react March 28, 2025 15:53 View deployment

SutuSebastian merged commit bab6c75 into themesberg:main Mar 29, 2025
8 checks passed

This was referenced Mar 29, 2025

Version Packages #1553

Merged

Version Packages cogor/flowbite-react#46

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ui): make drawer close button type button #1552

fix(ui): make drawer close button type button #1552

bigbyte-stuart commented Mar 27, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Mar 27, 2025 •

edited

Loading

vercel bot commented Mar 27, 2025 •

edited

Loading

coderabbitai bot commented Mar 27, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

SutuSebastian left a comment

vercel bot commented Mar 27, 2025

bigbyte-stuart commented Mar 27, 2025

bigbyte-stuart commented Mar 28, 2025

SutuSebastian commented Mar 28, 2025

bigbyte-stuart commented Mar 28, 2025

fix(ui): make drawer close button type button #1552

fix(ui): make drawer close button type button #1552

Conversation

bigbyte-stuart commented Mar 27, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

Summary by CodeRabbit

changeset-bot bot commented Mar 27, 2025 • edited Loading

🦋 Changeset detected

vercel bot commented Mar 27, 2025 • edited Loading

coderabbitai bot commented Mar 27, 2025 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

SutuSebastian left a comment

Choose a reason for hiding this comment

vercel bot commented Mar 27, 2025

bigbyte-stuart commented Mar 27, 2025

bigbyte-stuart commented Mar 28, 2025

SutuSebastian commented Mar 28, 2025

bigbyte-stuart commented Mar 28, 2025

bigbyte-stuart commented Mar 27, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Mar 27, 2025 •

edited

Loading

vercel bot commented Mar 27, 2025 •

edited

Loading

coderabbitai bot commented Mar 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)