Skip to content

fix(ui): make drawer close button type button #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2025
Merged

fix(ui): make drawer close button type button #1552

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e6c43a
fix(ui): make drawer close button type button
bigbyte-stuart Mar 27, 2025
efc7403
chore: add changeset
bigbyte-stuart Mar 27, 2025
402e563
trigger build
bigbyte-stuart Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bun.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
},
"packages/cli": {
"name": "create-flowbite-react",
"version": "1.0.8",
"version": "1.1.1",
"bin": {
"create-flowbite-react": "./dist/index.js",
},
Expand All @@ -109,7 +109,7 @@
},
"packages/ui": {
"name": "flowbite-react",
"version": "0.10.2",
"version": "0.11.5",
"bin": {
"flowbite-react": "./dist/cli/bin.js",
},
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/components/Drawer/DrawerHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export const DrawerHeader = forwardRef<HTMLDivElement, DrawerHeaderProps>((props
<TitleIcon aria-hidden className={theme.inner.titleIcon} />
{title}
</h5>
<button onClick={onClose} data-testid="close-drawer" className={theme.inner.closeButton}>
<button onClick={onClose} type="button" data-testid="close-drawer" className={theme.inner.closeButton}>
<CloseIcon aria-hidden className={theme.inner.closeIcon} />
<span className={theme.inner.titleCloseIcon}>Close menu</span>
</button>
Expand Down