Skip to content

fix(base-state-machine): prevent processing event twice in state machine#10730

Merged
rafaeltonholo merged 2 commits into
thunderbird:mainfrom
rafaeltonholo:fix/10729/base-state-machine-viewmodel-processing-event-twice
Mar 27, 2026
Merged

fix(base-state-machine): prevent processing event twice in state machine#10730
rafaeltonholo merged 2 commits into
thunderbird:mainfrom
rafaeltonholo:fix/10729/base-state-machine-viewmodel-processing-event-twice

Conversation

@rafaeltonholo
Copy link
Copy Markdown
Member

Tasks

Fixes #10729.

Description

The BaseStateMachineViewModel was triggering the stateMachine.process(event) twice, causing events to be duplicated.

This PR removes this unnecessary duplication.

Changes:

  • Remove stateMachine.process(event) from BaseStateMachineViewModel line 111
  • Rename StateMachineViewModelTest to BaseStateMachineViewModelTest to match the correct test subject class

@github-actions
Copy link
Copy Markdown
Contributor

Missing report label. Set exactly one of: report: include, report: exclude OR report: highlight.

@github-actions github-actions Bot added the tb-team Tasks and features handled by project maintainers label Mar 24, 2026
@rafaeltonholo rafaeltonholo requested review from dani-zilla and removed request for jbott-tbird March 24, 2026 12:30
@rafaeltonholo rafaeltonholo added the report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). label Mar 24, 2026
Copy link
Copy Markdown
Contributor

@dani-zilla dani-zilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rafaeltonholo rafaeltonholo merged commit 4d6a8fa into thunderbird:main Mar 27, 2026
19 of 20 checks passed
@rafaeltonholo rafaeltonholo deleted the fix/10729/base-state-machine-viewmodel-processing-event-twice branch March 27, 2026 20:25
@thunderbird-botmobile thunderbird-botmobile Bot added this to the Thunderbird 19 milestone Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). tb-team Tasks and features handled by project maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ML 0.5/MVI.01.5] - BaseStateMachineViewModel process events twice

3 participants