Skip to content

fix(base-state-machine): prevent processing event twice in state machine #10730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafaeltonholo merged 2 commits into from
Mar 27, 2026
Merged

fix(base-state-machine): prevent processing event twice in state machine #10730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d28fee6
fix(base-state-machine): prevent processing event twice in state machine
rafaeltonholo Mar 24, 2026
09d7801
refactor(base-state-machine): rename StateMachineViewModelTest to Bas…
rafaeltonholo Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...n/src/main/kotlin/net/thunderbird/core/ui/compose/common/mvi/BaseStateMachineViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ abstract class BaseStateMachineViewModel<TState : Any, TEvent : Any, TUiSideEffe
.filter { it.accept(event, newState) }
.forEach { it.handle(event, oldState = currentState, newState) }
}
stateMachine.process(event)
}
}
}
19 changes: 18 additions & 1 deletion ...e/common/mvi/StateMachineViewModelTest.kt → ...mmon/mvi/BaseStateMachineViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import net.thunderbird.core.logging.Logger
import net.thunderbird.core.logging.testing.TestLogger
import net.thunderbird.core.testing.coroutines.MainDispatcherHelper

class StateMachineViewModelTest {
class BaseStateMachineViewModelTest {

@OptIn(ExperimentalCoroutinesApi::class)
private val mainDispatcher = MainDispatcherHelper(UnconfinedTestDispatcher())
Expand Down Expand Up @@ -136,6 +136,19 @@ class StateMachineViewModelTest {
assertThat(eventTwoHandled).isTrue()
}

@Test
fun `event() should process an event only once when dispatched`() = runTest {
val stateMachine = FakeStateMachine("Initial state")
val viewModel = TestStateMachineViewModel(
initialState = "Initial state",
stateMachine = stateMachine,
)

viewModel.event("Test event")

assertThat(stateMachine.processCount).isEqualTo(1)
}

@Test
fun `should trigger side effect handlers on state change`() = runTest {
var sideEffectTriggered = false
Expand Down Expand Up @@ -183,7 +196,11 @@ class StateMachineViewModelTest {
private val _currentState = MutableStateFlow(initialState)
override val currentState: StateFlow<String> = _currentState.asStateFlow()

var processCount = 0
private set

override suspend fun process(event: String): String {
processCount++
_currentState.value = event
return _currentState.value
}
Expand Down
Loading