-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): implement top-level-await and native import support #12347
base: master
Are you sure you want to change the base?
Conversation
|
8da8c50
to
ae6f6aa
Compare
So, this is very much related to #11693 - we're hitting the same basic code path. My PR attempts to move iOS to match Android's require/Module implementation and move all JS code into a new ti.kernel.js that we load on both platforms. (So startup becomes more like Android's 2-pass system where you load the kernel/kroll.js equivalent to bootstrap the |
@garymathews Can we break out the V8 update/C++14 change to a separate PR we can land earlier? I assume that'd be fairly straight-forward to do and CR to get landed. Also, I'd expect that this will keep shifting as a target since we're going to want to ensure the absolute latest stable V8 release prior to feature freeze (which I'd anticipate would like end up 8.8 for this cycle?) |
57b1e43
to
8b6c856
Compare
2c7e3ab
to
cb513d8
Compare
6e03e15
to
64baf14
Compare
6b00b5f
to
238605c
Compare
@garymathews Is there a possibility to finish this pull request? 😇 It would be an amazing improvement! |
export
supportimport
has been implemented natively, although it currently still piggybacks off ourrequire
implementation as it parses paths and handles native modules well8.7.220.29
v8.h
TODO
Modernize ourruntime/common/src/js/*.js
filesmoduleContexts
runAsScript
node-titanium-sdk
to allow for nativeimport/export
and top-level-await supportTIMOB-28286