fix(operation_mode_transition_manager): modify the engage condition#2271
Merged
rej55 merged 2 commits intobeta/v0.48from Aug 5, 2025
Merged
fix(operation_mode_transition_manager): modify the engage condition#2271rej55 merged 2 commits intobeta/v0.48from
rej55 merged 2 commits intobeta/v0.48from
Conversation
…utowarefoundation#11097) * check engage on driving before check engage condition Signed-off-by: Zhi Wang <zhi.wang@tier4.jp> * fix Signed-off-by: Zhi Wang <zhi.wang@tier4.jp> --------- Signed-off-by: Zhi Wang <zhi.wang@tier4.jp>
zhiwango
requested review from
TakaHoribe,
isamu-takagi,
takayuki5168 and
tkimura4
as code owners
zhiwango
removed request for
TakaHoribe,
isamu-takagi,
takayuki5168 and
tkimura4
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
rej55
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will cherry-pick autowarefoundation#11097 that fixes a problem.
When
check_engage_condition_is set asfalse,bool isModeChangeAvailable()will returntruebeforeenable_engage_on_driving_is checked.Here is the ticket
For more details, please refer to this thread.