Skip to content

fix(pointcloud_preprocessor): handle empty pointclouds in pickup_base (#11003)#2273

Merged
rej55 merged 1 commit intobeta/v0.48from
cherry-pick/pick_filter
Aug 5, 2025
Merged

fix(pointcloud_preprocessor): handle empty pointclouds in pickup_base (#11003)#2273
rej55 merged 1 commit intobeta/v0.48from
cherry-pick/pick_filter

Conversation

@KYabuuchi
Copy link

Descritpion

Original PR description

Description

The pickup_based_downsample_filter currently fails to publish an output when it receives an empty pointcloud.

The expected behavior is to publish an empty pointcloud when the input is also empty. This PR fixes the node to ensure this behavior.

To verify the fix, I've added integration tests for both single-point and empty pointclouds.

Note: These integration tests are time-consuming. I plan to replace them with faster unit tests for the filter() function in a future PR.

Related links

Private Links:

…d_downsample_filter (autowarefoundation#11003)

* feat(pointcloud_preprocessor): add integration test  for pickup based downsamplie filter node

Signed-off-by: Takahisa.Ishikawa <takahisa.ishikawa@tier4.jp>

* feat(pointcloud_preprocessor): add test for pickup based downsample filter with zero length pointcloud

that test will fail for now.

Signed-off-by: Takahisa.Ishikawa <takahisa.ishikawa@tier4.jp>

* refactor(pointcloud_preprocessor): simplify test for pickup based downsample filter

Signed-off-by: Takahisa.Ishikawa <takahisa.ishikawa@tier4.jp>

* fix(pointcloud_preprocessor): enable to output zero length pointcloud

Signed-off-by: Takahisa.Ishikawa <takahisa.ishikawa@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Takahisa.Ishikawa <takahisa.ishikawa@tier4.jp>
Co-authored-by: Takahisa.Ishikawa <takahisa.ishikawa@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@KYabuuchi KYabuuchi marked this pull request as ready for review August 5, 2025 00:30
@KYabuuchi KYabuuchi requested a review from rej55 August 5, 2025 00:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2025

@rej55 rej55 merged commit 6fcdf86 into beta/v0.48 Aug 5, 2025
38 of 41 checks passed
@rej55 rej55 deleted the cherry-pick/pick_filter branch August 5, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants