Skip to content

feat(autoware_cuda_pointcloud_preprocessor): cherry picking cuda_polar_voxel_outlier_filter#2282

Merged
manato merged 9 commits intosensing/experiment/2025-08-07from
sensing/experiment/2025-08-07_cuda_pp_polar_voxel
Aug 8, 2025
Merged

feat(autoware_cuda_pointcloud_preprocessor): cherry picking cuda_polar_voxel_outlier_filter#2282
manato merged 9 commits intosensing/experiment/2025-08-07from
sensing/experiment/2025-08-07_cuda_pp_polar_voxel

Conversation

@manato
Copy link

@manato manato commented Aug 6, 2025

This PR cherry-picks CUDA implementation of the polar voxel outlier filter, which is going to be introduced by

@github-actions
Copy link

github-actions bot commented Aug 6, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mojomex
Copy link

mojomex commented Aug 6, 2025

Will merge once CI build completes (passes).

@manato manato marked this pull request as draft August 6, 2025 13:41
@manato
Copy link
Author

manato commented Aug 6, 2025

For the following reasons, I switched this PR to draft status temporarily. Sorry for making noise.

  • breaking changes are introduced in the CPU implementation
  • It revealed that cuda_pointcloud_preprocessor outputs data in XYZIRC format, which is incompatible with the current cuda_polar_voxel_outlier_filter.

@drwnz
Copy link

drwnz commented Aug 6, 2025

Shall we revert back to an earlier commit of the CPU version for testing?
Apologies for the breaking changes today 😢 what was supposed to be a simple refactor got away a bit.

@manato manato marked this pull request as ready for review August 8, 2025 01:33
@manato manato force-pushed the sensing/experiment/2025-08-07_cuda_pp_polar_voxel branch from a0badb0 to 8dcff64 Compare August 8, 2025 01:33
@manato manato requested a review from drwnz August 8, 2025 01:34
manato and others added 9 commits August 8, 2025 10:38
Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>

WIP: use cuda::std::optional. compile passed

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>

wip: version 1

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>

wip: update

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>

wip: update launcher

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
… outlier filter in cuda_pointcloud_preprocessor

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
- add SI unit postfix
- deprecate `secondary_return_type`
  - and think points with non-primary return value as points with secondary return

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
…cted memory release during async copy

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
@manato manato force-pushed the sensing/experiment/2025-08-07_cuda_pp_polar_voxel branch from 8dcff64 to 381767a Compare August 8, 2025 01:38
@manato manato merged commit 0efec6a into sensing/experiment/2025-08-07 Aug 8, 2025
17 of 20 checks passed
@manato manato deleted the sensing/experiment/2025-08-07_cuda_pp_polar_voxel branch August 8, 2025 01:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants