Skip to content

fix(post_process): pass vehicle_model to planning analyzer for DAC compatibility#344

Merged
beomseok-kimm merged 1 commit intodevelopfrom
fix/pass-vehicle-model-to-planning-data-analyzer
Mar 31, 2026
Merged

fix(post_process): pass vehicle_model to planning analyzer for DAC compatibility#344
beomseok-kimm merged 1 commit intodevelopfrom
fix/pass-vehicle-model-to-planning-data-analyzer

Conversation

@beomseok-kimm
Copy link
Copy Markdown
Contributor

Types of PR

  • New Features
  • Upgrade of existing features
  • Bugfix

Description

This PR fixes the missing vehicle_model argument forwarding when driving_log_replayer_v2 runs autoware_planning_data_analyzer during time_step_based_trajectory post-processing.

Without this change, post-processing can analyze the recorded bag, but DAC (Drivable Area Compliance) may remain unavailable because autoware_planning_data_analyzer cannot load vehicle geometry unless vehicle_model is passed through to planning_data_analyzer.launch.xml.

This change was made to keep DLR post-processing compatible with the DAC support added in:

How to review this PR

  1. Check driving_log_replayer_v2/launch/post_process.launch.py.
  2. Confirm vehicle_model is forwarded to both analyzer invocations in time_step_based_trajectory():
    • optimized trajectory analysis
    • raw diffusion trajectory analysis
  3. Run a time_step_based_trajectory scenario with a valid VehicleModel such as lexus.
  4. Confirm the analyzer launch receives vehicle_model:=<scenario vehicle model>.
  5. Confirm DAC is no longer blocked by missing vehicle info when route and /map/vector_map are present in the result bag.

Example DLR run:

ros2 launch driving_log_replayer_v2 use_case.launch.py \
  scenario_path:=/path/to/scenario.yaml \
  dataset_dir:=/path/to/dataset_dir \
  output_dir:=/tmp/dlr_output

Example expected analyzer command shape during post-process:

ros2 launch autoware_planning_data_analyzer planning_data_analyzer.launch.xml \
  bag_path:=/tmp/dlr_output/result_bag/result_bag_0.mcap \
  output_dir:=/tmp/dlr_output/result_archive/optimized \
  vehicle_model:=lexus \
  trajectory_topic:=/planning/trajectory \
  open_loop_metric_variant:=optimized

Others

  • This change only forwards an already-known DLR scenario field (vehicle_model) into analyzer post-processing.
  • It does not change the analyzer logic itself.
  • DAC still requires route and /map/vector_map to be present in the recorded result bag.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes time_step_based_trajectory post-processing in driving_log_replayer_v2 so autoware_planning_data_analyzer receives the scenario’s vehicle_model, enabling vehicle-geometry-dependent metrics like DAC during analysis.

Changes:

  • Forward vehicle_model to the planning analyzer invocation for optimized trajectory analysis.
  • Forward vehicle_model to the planning analyzer invocation for raw diffusion trajectory analysis.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@go-sakayori go-sakayori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@beomseok-kimm
Copy link
Copy Markdown
Contributor Author

@xtk8532704 Kem-san, LGTU????

@beomseok-kimm beomseok-kimm merged commit 1b7c5bc into develop Mar 31, 2026
10 checks passed
@beomseok-kimm beomseok-kimm deleted the fix/pass-vehicle-model-to-planning-data-analyzer branch March 31, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants