fix(post_process): pass vehicle_model to planning analyzer for DAC compatibility#344
Merged
beomseok-kimm merged 1 commit intodevelopfrom Mar 31, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes time_step_based_trajectory post-processing in driving_log_replayer_v2 so autoware_planning_data_analyzer receives the scenario’s vehicle_model, enabling vehicle-geometry-dependent metrics like DAC during analysis.
Changes:
- Forward
vehicle_modelto the planning analyzer invocation for optimized trajectory analysis. - Forward
vehicle_modelto the planning analyzer invocation for raw diffusion trajectory analysis.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Contributor
Author
|
@xtk8532704 Kem-san, LGTU???? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Types of PR
Description
This PR fixes the missing
vehicle_modelargument forwarding whendriving_log_replayer_v2runsautoware_planning_data_analyzerduringtime_step_based_trajectorypost-processing.Without this change, post-processing can analyze the recorded bag, but
DAC (Drivable Area Compliance)may remain unavailable becauseautoware_planning_data_analyzercannot load vehicle geometry unlessvehicle_modelis passed through toplanning_data_analyzer.launch.xml.This change was made to keep DLR post-processing compatible with the DAC support added in:
How to review this PR
driving_log_replayer_v2/launch/post_process.launch.py.vehicle_modelis forwarded to both analyzer invocations intime_step_based_trajectory():time_step_based_trajectoryscenario with a validVehicleModelsuch aslexus.vehicle_model:=<scenario vehicle model>.DACis no longer blocked by missing vehicle info when route and/map/vector_mapare present in the result bag.Example DLR run:
Example expected analyzer command shape during post-process:
Others
vehicle_model) into analyzer post-processing.DACstill requires route and/map/vector_mapto be present in the recorded result bag.