refactors and small fixes for ParameterValueDistribution-related codes (stochastic)#1510
Open
refactors and small fixes for ParameterValueDistribution-related codes (stochastic)#1510
Conversation
…tributionSet::elements
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
…into parameter_value_distribution_1
This reverts commit 66853af.
HansRobo
changed the title
Failure optional scenariosNote This is an experimental check and does not block merging the pull-request. scenario failed: execution_time_test <failure type="SimulationFailure" message="CustomCommandAction typed "exitFailure" was triggered by the named Conditions {"update time checker", "avoid startup"}: {"update time checker": Is the /simulation/interpreter/execution_time/update (= 0.007761999999999999802491323919) is greaterThan 0.005?}, {"avoid startup": Is the simulation time (= 1.850000000000000976996261670138) is greaterThan 1.000000000000000000000000000000?}" /> |
HansRobo
added
bump patch
|
|
HansRobo
requested review from
hakuturu583,
shouth and
takanotaiga
as code owners
|
|
This PR has failed the SonarQube scan. Please check the details in the SonarQube dashboard. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Background
There are a large diff in #1253.
This pull-request is a part of it.
Details
Change way to manage a shared resource for stochastic parameter distributions
Use
Scope::random_engineinstead ofScope::seedas shared resource for stochastic parameter distributions.Fixed member element names
Improve detailed implementation
Stop using XXAdaptor for member initialization
References
Destructive Changes
Known Limitations
In this pull-request, tests are out-of-scope and will be introduced another pull-request.