Fixed a bug in Phase::evaluate where states were missing except for the last state when multiple states existed for the same ID

[HansRobo]

Description

Abstract

When multiple TrafficSignalState are specified in Phase in TrafficSignalController, states except the last one are missing.
This is because TrafficSignalState::evaluate overwrite the state of traffic light every time.
The traffic light state manipulation previously only provided an overwrite operation with set, but by adding clear/add, I have made it possible to perform flexible operations and reset the state only once per frame in this pull-request.

Details

Test with TrafficSignals.yaml

Traffic lights output comparison when traffic signal controller controller-1 is on phase-3.

before this pull-request

---
traffic_lights:
- lanelet_way_id: 34836
  traffic_light_bulbs:
  - enum_revision: 0
    color: 1
    shape: 1
    status: 2
    confidence: 1.0
- lanelet_way_id: 34802
  traffic_light_bulbs:
  - enum_revision: 0
    color: 3
    shape: 2
    status: 2
    confidence: 1.0

after this pull-request

---
traffic_lights:
- lanelet_way_id: 34836
  traffic_light_bulbs:
  - enum_revision: 0
    color: 1
    shape: 1
    status: 2
    confidence: 1.0
- lanelet_way_id: 34802
  traffic_light_bulbs:
  - enum_revision: 0
    color: 3
    shape: 2
    status: 2
    confidence: 1.0
  - enum_revision: 0 # this bulb is missing before this pull-request
    color: 1
    shape: 1
    status: 2
    confidence: 1.0

References

Regression Test: OK

Destructive Changes

None

Known Limitations

None

[github-actions]

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

• Is this pull request written in a way that is easy to read from a third-party perspective?
• Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
• If this pull request contains a destructive change, does this pull request contain the migration guide?
• Labels of this pull request are valid?
• All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
• The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
13.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud