Do not treat deprecation as an error#1744
Merged
Conversation
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
HansRobo
added
the
bump patch
HansRobo
requested review from
hakuturu583,
shouth,
takanotaiga and
yamacir-kit
as code owners
yamacir-kit
approved these changes
Nov 20, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Abstract
We have been upgrading deprecation warnings to errors in some packages, but I am removing this in this pull-request.
Turning warnings into errors is useful for maintaining good code, but turning deprecation into errors can cause build errors, preventing external libraries from implementing a transition period based on a normal API lifecycle.
Background
After awf/autoware_lanelet2_extension#88 build error has occured on build test.
https://github.com/tier4/scenario_simulator_v2/actions/runs/19520881881
However, the pull request does not make any breaking changes to the API, and follows the correct API replacement practice of using deprecation.
Destructive Changes
None
Known Limitations
None