possible fix for double event registration in child models when calling events from parent trait use#143
Open
solis-eduardo wants to merge 2 commits intotighten:mainfrom
Open
possible fix for double event registration in child models when calling events from parent trait use#143solis-eduardo wants to merge 2 commits intotighten:mainfrom
solis-eduardo wants to merge 2 commits intotighten:mainfrom
Conversation
…ng events from parent trait use
Author
|
Forgot to mention: it can be bypassed by declaring a empty public static function boot() {
parent::boot();
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came across this issue when using
owen-it/laravel-auditing.My
Modelclass uses theAuditabletrait, but the events are registered twice becauseparentIsBootingonly accounts for traits used by the parent class itself, to solve this problem I created a static array for parent classes and added an alternativeissetverification, similar to the preexisting$parentBootMethodslogic.