Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/HasChildren.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ trait HasChildren
*/
protected static $parentBootMethods;

/**
* @var array
*/
protected static $parentClasses;

/**
* @var bool
*/
Expand Down Expand Up @@ -57,11 +62,21 @@ protected static function parentIsBooting(): bool
self::$parentBootMethods = array_flip(self::$parentBootMethods);
}

if (! isset(self::$parentClasses)) {
foreach (class_parents(self::class) as $parent) {
self::$parentClasses[$parent] = true;
}
}

foreach (debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS) as $trace) {
$class = isset($trace['class']) ? $trace['class'] : null;
$function = isset($trace['function']) ? $trace['function'] : '';
if (! isset($trace['class']) || ! isset($trace['function'])) {
continue;
}

$class = $trace['class'];
$function = $trace['function'];

if ($class === self::class && isset(self::$parentBootMethods[$function])) {
if (($class === self::class || isset(self::$parentClasses[$class])) && isset(self::$parentBootMethods[$function])) {
return true;
}
}
Expand Down
12 changes: 12 additions & 0 deletions tests/Features/ParentsObserveChildrenTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@

namespace Parental\Tests\Features;

use Parental\Tests\Models\Animal;
use Parental\Tests\Models\Car;
use Parental\Tests\Models\Cat;
use Parental\Tests\Models\Dog;
use Parental\Tests\Models\Train;
use Parental\Tests\Models\Vehicle;
use Parental\Tests\Observers\CarObserver;
Expand Down Expand Up @@ -93,4 +96,13 @@ public function registering_events_in_parent_boot_only_triggers_once()
$car = Car::create();
$this->assertEquals(1, $car->boot_count);
}

/** @test */
public function registering_events_in_parent_trait_only_triggers_once()
{
Cat::create();
Dog::create();

$this->assertEquals(2, Animal::$created);
}
}
15 changes: 15 additions & 0 deletions tests/Models/Animal.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?php

namespace Parental\Tests\Models;

use Parental\HasChildren;

class Animal extends CountedModel
{
use HasChildren;

protected $childTypes = [
'cat' => Cat::class,
'dog' => Dog::class,
];
}
10 changes: 10 additions & 0 deletions tests/Models/Cat.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

namespace Parental\Tests\Models;

use Parental\HasParent;

class Cat extends Animal
{
use HasParent;
}
19 changes: 19 additions & 0 deletions tests/Models/CountedModel.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php

namespace Parental\Tests\Models;

use Illuminate\Database\Eloquent\Model;
use Parental\Tests\Traits\CountsCreatedModels;

class CountedModel extends Model
{
use CountsCreatedModels;

public static int $created = 0;

protected $fillable = [
'type', 'name',
];

protected $guarded = [];
}
10 changes: 10 additions & 0 deletions tests/Models/Dog.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

namespace Parental\Tests\Models;

use Parental\HasParent;

class Dog extends Animal
{
use HasParent;
}
13 changes: 13 additions & 0 deletions tests/Observers/ModelCreatedObserver.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

namespace Parental\Tests\Observers;

use Parental\Tests\Models\CountedModel;

class ModelCreatedObserver
{
public function created(CountedModel $model)
{
$model::$created++;
}
}
7 changes: 7 additions & 0 deletions tests/TestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,13 @@ public function runMigrations()
$table->string('skill_level')->nullable();
$table->timestamps();
});

Schema::create('animals', function ($table) {
$table->increments('id');
$table->string('type')->nullable();
$table->string('name')->nullable();
$table->timestamps();
});
}

protected function getEnvironmentSetUp($app)
Expand Down
13 changes: 13 additions & 0 deletions tests/Traits/CountsCreatedModels.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

namespace Parental\Tests\Traits;

use Parental\Tests\Observers\ModelCreatedObserver;

trait CountsCreatedModels
{
public static function bootCountsCreatedModels(): void
{
static::observe(new ModelCreatedObserver);
}
}