Refactor bit by bit by brianmcgillion · Pull Request #1729 · tiiuae/ghaf

brianmcgillion · 2026-02-05T01:24:09Z

Description of Changes

Type of Change

New Feature
Bug Fix
Improvement / Refactor

Related Issues / Tickets

Checklist

Clear summary in PR description
Detailed and meaningful commit message(s)
Commits are logically organized and squashed if appropriate
Contribution guidelines followed
Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
Author has run make-checks and it passes
All automatic GitHub Action checks pass - see actions
Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

Installation Method

Requires full re-installation
Can be updated with nixos-rebuild ... switch
Other:

Test Steps To Verify:

...

Try to start breaking the anti-pattern that we have configHost = config, which makes navigating and understanding relationships very difficult to manage. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

add more configs to globalConfig and extend it across all the sysvms and the baseline appvm Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

Start the migration to extendModules in a hybrid way. Include the easy to move components first and keep extraModules for now. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

no longer depend on extraModules being set inside the guivm. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

Convert to composable vm structure. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

continue the migration to composable system. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

remove the legacy extraModules interface from the netvm. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

Move the stunnel and the alloy listener to internal addresses as they are talking withing the admin vm. so no need to route out and back. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

Needed to set the correct script version to make it work, upstream made the qspi flash (initrdFlashScript) the default, so we must choose the legacy for now. Can be replaced in future, but we need to add the actual filesystem information to the flash script buider, along with the qspi, in order to make it work. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

mbssrc

Nothing new from what we discussed already - LGTM

brianmcgillion temporarily deployed to internal February 5, 2026 01:24 — with GitHub Actions Inactive

brianmcgillion force-pushed the refactor-bit-by-bit branch from d5afeff to a7becc6 Compare February 5, 2026 06:50

brianmcgillion temporarily deployed to internal February 5, 2026 06:50 — with GitHub Actions Inactive

brianmcgillion temporarily deployed to internal February 5, 2026 06:51 — with GitHub Actions Inactive

brianmcgillion force-pushed the refactor-bit-by-bit branch from a7becc6 to a18c70e Compare February 5, 2026 15:58

brianmcgillion temporarily deployed to internal February 5, 2026 15:58 — with GitHub Actions Inactive

brianmcgillion force-pushed the refactor-bit-by-bit branch from a18c70e to e7414e6 Compare February 5, 2026 16:46

brianmcgillion temporarily deployed to internal February 5, 2026 16:46 — with GitHub Actions Inactive

brianmcgillion temporarily deployed to internal February 5, 2026 16:47 — with GitHub Actions Inactive

brianmcgillion temporarily deployed to internal February 6, 2026 05:45 — with GitHub Actions Inactive

brianmcgillion force-pushed the refactor-bit-by-bit branch from 424a0f7 to cf4f5f3 Compare February 6, 2026 17:31

brianmcgillion temporarily deployed to internal February 6, 2026 17:31 — with GitHub Actions Inactive

brianmcgillion added 14 commits February 7, 2026 14:37

global-config: create a global configuration

7c79999

Try to start breaking the anti-pattern that we have configHost = config, which makes navigating and understanding relationships very difficult to manage. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

globalConfig: Extend the use into all vms

e319633

add more configs to globalConfig and extend it across all the sysvms and the baseline appvm Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

guivm: move towards using extendModules

7f3b42e

Start the migration to extendModules in a hybrid way. Include the easy to move components first and keep extraModules for now. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

guivm: complete the move to composed vm

4e1868c

no longer depend on extraModules being set inside the guivm. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

adminvm: convert to using extendModules

be398c7

Convert to composable vm structure. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

idsvm: migrate to using the extendModules

9210514

continue the migration to composable system. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

audiovm: migrate to extendModules composition

6baabbe

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

netvm: migrate to using extendModules pattern

fec5b04

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

netvm: ensure orin uses basic hw config

6adfde8

remove the legacy extraModules interface from the netvm. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

appvms: migrate all to using the extendModules

781696b

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

guivm-base: remove this

cd3d974

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

orin: adminvm to use the extendModules construct

6f93795

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

baseVM: export through the flakes for downstream

8efb314

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

split physical hardware from vm resources

0c07b50

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

brianmcgillion force-pushed the refactor-bit-by-bit branch from 804a3f0 to d3a09b9 Compare February 9, 2026 00:50

brianmcgillion temporarily deployed to internal February 9, 2026 00:50 — with GitHub Actions Inactive

brianmcgillion temporarily deployed to internal February 9, 2026 04:15 — with GitHub Actions Inactive

brianmcgillion force-pushed the refactor-bit-by-bit branch from 938a98e to 74098b7 Compare February 10, 2026 06:09

brianmcgillion temporarily deployed to internal February 10, 2026 06:09 — with GitHub Actions Inactive

brianmcgillion force-pushed the refactor-bit-by-bit branch from 74098b7 to d88adf9 Compare February 10, 2026 20:25

brianmcgillion temporarily deployed to internal February 10, 2026 20:26 — with GitHub Actions Inactive

brianmcgillion added 5 commits February 11, 2026 01:35

cleaning and cleaning

aac87f0

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

logs: move stunnel and admin-vm logging to internal

6608f0f

Move the stunnel and the alloy listener to internal addresses as they are talking withing the admin vm. so no need to route out and back. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

docs: cleanup

6bd5874

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

fix statix warnings

7f47758

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

brianmcgillion force-pushed the refactor-bit-by-bit branch from d88adf9 to 7f47758 Compare February 11, 2026 06:46

brianmcgillion temporarily deployed to internal February 11, 2026 06:46 — with GitHub Actions Inactive

brianmcgillion temporarily deployed to internal February 11, 2026 07:30 — with GitHub Actions Inactive

brianmcgillion temporarily deployed to internal February 11, 2026 07:31 — with GitHub Actions Inactive

last alignment fixes

bcd38e5

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>

brianmcgillion force-pushed the refactor-bit-by-bit branch from 8e70ed3 to bcd38e5 Compare February 11, 2026 07:49

brianmcgillion temporarily deployed to internal February 11, 2026 07:49 — with GitHub Actions Inactive

brianmcgillion requested a review from mbssrc February 11, 2026 08:23

mbssrc approved these changes Feb 11, 2026

View reviewed changes

brianmcgillion merged commit 8d1e927 into tiiuae:main Feb 11, 2026
32 checks passed

brianmcgillion deleted the refactor-bit-by-bit branch February 11, 2026 14:46

brianmcgillion mentioned this pull request Feb 11, 2026

nvidia-jetpack: move pre-flash commands into writeShellApplication #1740

Merged

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Refactor bit by bit#1729

Refactor bit by bit#1729
brianmcgillion merged 30 commits intotiiuae:mainfrom
brianmcgillion:refactor-bit-by-bit

brianmcgillion commented Feb 5, 2026 •

edited by mbssrc

Loading

Uh oh!

mbssrc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

brianmcgillion commented Feb 5, 2026 • edited by mbssrc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Changes

Type of Change

Related Issues / Tickets

Checklist

Testing Instructions

Applicable Targets

Installation Method

Test Steps To Verify:

Uh oh!

mbssrc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

brianmcgillion commented Feb 5, 2026 •

edited by mbssrc

Loading