Skip to content

Comments

refactor: embrace the features!#1749

Merged
brianmcgillion merged 2 commits intotiiuae:mainfrom
kajusnau:embrace-refactor
Feb 13, 2026
Merged

refactor: embrace the features!#1749
brianmcgillion merged 2 commits intotiiuae:mainfrom
kajusnau:embrace-refactor

Conversation

@kajusnau
Copy link
Collaborator

@kajusnau kajusnau commented Feb 13, 2026

Description of Changes

  • Added power and perf modules as features in global config
  • Adjusted net, gui, and audio vms to check feature flags
  • Refactored global config to use mkEnableOption where possible
  • Re-enabled power manager for net-vm

Following https://ghaf.tii.ae/ghaf/dev/guides/writing-modules/ and https://ghaf.tii.ae/ghaf/dev/guides/adding-features/

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Regression tests, if any

- add power and perf modules as features in global config
- adjust net, gui, and audio vms to check feature flags
- refactor global config to use mkEnableOption where possible

Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@brianmcgillion brianmcgillion merged commit 3eb7eb4 into tiiuae:main Feb 13, 2026
32 checks passed
@kajusnau kajusnau deleted the embrace-refactor branch February 16, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants