-
Notifications
You must be signed in to change notification settings - Fork 250
upgrade grpc to v1.73 #1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
upgrade grpc to v1.73 #1779
Conversation
Signed-off-by: Ruihao Chen <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @joechenrh! |
Signed-off-by: Ruihao Chen <[email protected]>
|
/hold |
Signed-off-by: Ruihao Chen <[email protected]>
2bcb5a5 to
9bd9fb0
Compare
|
/ok-to-test |
|
@joechenrh: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/unhold |
Signed-off-by: Ruihao Chen <[email protected]>
|
/run-all-tests |
|
Previously, grpc was upgraded to 1.64 and reverted (by #1369) due to errors in TiFlash regression tests. So I keep using old API I've ran a test internally with this branch. The plan ID is 7972306, and you can check the result. (Although I suspect that error is not related to grpc API change because it seems like we couldn't connect to |
|
This would fix #1789, right? |
From v1.66,
WithRecvBufferPoolhas been renamed toWithBufferPool.Besides, buffer pool is enabled by default. That is, the default buffer pool of client is changed from
nopBufferPooltotieredBufferPool.As this option was introduced in #1132, and not enabled in TiKV, we keep the old logic to use a
NopBufferPoolas default value.Why upgrade grpc
Because we are using some expermential API that was already renamed. This will block those libraries that depend on this to use newer version of grpc. (And I found someone has already want to do this: #1672)