-
Notifications
You must be signed in to change notification settings - Fork 199
Draft: Experiments using Rapidhash #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hoxxep
wants to merge
7
commits into
tikv:master
Choose a base branch
from
hoxxep:rapidhash
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liam Gray <[email protected]>
Signed-off-by: Liam Gray <[email protected]>
Signed-off-by: Liam Gray <[email protected]>
Signed-off-by: Liam Gray <[email protected]>
Signed-off-by: Liam Gray <[email protected]>
Signed-off-by: Liam Gray <[email protected]>
Signed-off-by: Liam Gray <[email protected]>
hoxxep
commented
Mar 21, 2025
use fnv::FnvHasher; | ||
// TODO: experimenting, alternating while benchmarking | ||
// use fnv::FnvHasher; | ||
use rapidhash::RapidHasher as FnvHasher; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key lines to change to compare benchmarks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the back of #532, this is a PR with further benchmarks for replacing fnv with rapidhash.
Full disclosure, I'm the author of the rapidhash crate and was checking to see if it could give some easy wins.
Summary of findings:
The benchmarks are written as:
counter_with_mapped_labels
the original tests with very short field names around 4 characters (zwei).counter_with_mapped_mid_labels
a mid-size label of around 12 chars (midsize_zwei).counter_with_mapped_long_labels
a longer label of around 24 chars (longer_field_name_zwei).Benchmarking fnv vs. rapidhash actually entails commenting and uncommenting
vec.rs
lines 9 and 10.I would love to hear thoughts or see other benchmarks, otherwise if this is of interest I can benchmark on some AWS instances with different architectures.