Skip to content

Draft: Experiments using Rapidhash #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Draft: Experiments using Rapidhash #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
947534e
perf: optimise CounterVec hashing, enable other hashers
hoxxep Dec 12, 2024
95ad518
Remove nohash-hasher dependency
hoxxep Mar 20, 2025
56e7e60
Merge branch 'master' of github.com:tikv/rust-prometheus into hashing
hoxxep Mar 20, 2025
2289dce
Restrict nohash visibility explicitly
hoxxep Mar 20, 2025
8db16bc
Benchmarks and experiments using rapidhash instead of FNV
hoxxep Mar 20, 2025
e7668e3
Fix cargo fmt
hoxxep Mar 21, 2025
5257298
Merge branch 'master' of github.com:tikv/rust-prometheus into rapidhash
hoxxep Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ protobuf = { version = "^3.7.2", optional = true }
memchr = "^2.3"
reqwest = { version = "^0.12", features = ["blocking"], optional = true }
thiserror = "^2.0"
rapidhash = "1.4.0"

[target.'cfg(target_os = "linux")'.dependencies]
procfs = { version = "^0.17", optional = true, default-features = false }
Expand Down
146 changes: 146 additions & 0 deletions benches/counter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use criterion::{black_box, criterion_group, criterion_main, Criterion};
use fnv::FnvBuildHasher;
use prometheus::{Counter, CounterVec, IntCounter, Opts};
use rapidhash::RapidBuildHasher;
use std::collections::HashMap;
use std::sync::{atomic, Arc};
use std::thread;
Expand Down Expand Up @@ -69,6 +70,144 @@ fn bench_counter_with_mapped_labels_fnv(c: &mut Criterion) {
});
}

fn bench_counter_with_mapped_labels_rapidhash(c: &mut Criterion) {
let counter = CounterVec::new(
Opts::new("benchmark_counter", "A counter to benchmark it."),
&["one", "two", "three"],
)
.unwrap();

c.bench_function("counter_with_mapped_labels_rapidhash", |b| {
b.iter(|| {
let mut labels = HashMap::with_capacity_and_hasher(3, RapidBuildHasher::default());
labels.insert("two", "zwei");
labels.insert("one", "eins");
labels.insert("three", "drei");
counter.with(&black_box(labels)).inc();
})
});
}

fn bench_counter_with_mapped_mid_labels(c: &mut Criterion) {
let counter = CounterVec::new(
Opts::new("benchmark_counter", "A counter to benchmark it."),
&["midsize_one", "midsize_two", "midsize_three"],
)
.unwrap();

c.bench_function("counter_with_mapped_mid_labels", |b| {
b.iter(|| {
let mut labels = HashMap::with_capacity(3);
labels.insert("midsize_two", "midsize_zwei");
labels.insert("midsize_one", "midsize_eins");
labels.insert("midsize_three", "midsize_drei");
counter.with(&black_box(labels)).inc();
})
});
}

fn bench_counter_with_mapped_mid_labels_fnv(c: &mut Criterion) {
let counter = CounterVec::new(
Opts::new("benchmark_counter", "A counter to benchmark it."),
&["midsize_one", "midsize_two", "midsize_three"],
)
.unwrap();

c.bench_function("counter_with_mapped_mid_labels_fnv", |b| {
b.iter(|| {
let mut labels = HashMap::with_capacity_and_hasher(3, FnvBuildHasher::default());
labels.insert("midsize_two", "midsize_zwei");
labels.insert("midsize_one", "midsize_eins");
labels.insert("midsize_three", "midsize_drei");
counter.with(&black_box(labels)).inc();
})
});
}

fn bench_counter_with_mapped_mid_labels_rapidhash(c: &mut Criterion) {
let counter = CounterVec::new(
Opts::new("benchmark_counter", "A counter to benchmark it."),
&["midsize_one", "midsize_two", "midsize_three"],
)
.unwrap();

c.bench_function("counter_with_mapped_mid_labels_rapidhash", |b| {
b.iter(|| {
let mut labels = HashMap::with_capacity_and_hasher(3, RapidBuildHasher::default());
labels.insert("midsize_two", "midsize_zwei");
labels.insert("midsize_one", "midsize_eins");
labels.insert("midsize_three", "midsize_drei");
counter.with(&black_box(labels)).inc();
})
});
}

fn bench_counter_with_mapped_long_labels(c: &mut Criterion) {
let counter = CounterVec::new(
Opts::new("benchmark_counter", "A counter to benchmark it."),
&[
"longer_field_number_one",
"longer_field_number_two",
"longer_field_number_three",
],
)
.unwrap();

c.bench_function("counter_with_mapped_longer_labels", |b| {
b.iter(|| {
let mut labels = HashMap::with_capacity(3);
labels.insert("longer_field_number_two", "longer_field_number_zwei");
labels.insert("longer_field_number_one", "longer_field_number_eins");
labels.insert("longer_field_number_three", "longer_field_number_drei");
counter.with(&black_box(labels)).inc();
})
});
}

fn bench_counter_with_mapped_long_labels_fnv(c: &mut Criterion) {
let counter = CounterVec::new(
Opts::new("benchmark_counter", "A counter to benchmark it."),
&[
"longer_field_number_one",
"longer_field_number_two",
"longer_field_number_three",
],
)
.unwrap();

c.bench_function("counter_with_mapped_longer_labels_fnv", |b| {
b.iter(|| {
let mut labels = HashMap::with_capacity_and_hasher(3, FnvBuildHasher::default());
labels.insert("longer_field_number_two", "longer_field_number_zwei");
labels.insert("longer_field_number_one", "longer_field_number_eins");
labels.insert("longer_field_number_three", "longer_field_number_drei");
counter.with(&black_box(labels)).inc();
})
});
}

fn bench_counter_with_mapped_long_labels_rapidhash(c: &mut Criterion) {
let counter = CounterVec::new(
Opts::new("benchmark_counter", "A counter to benchmark it."),
&[
"longer_field_number_one",
"longer_field_number_two",
"longer_field_number_three",
],
)
.unwrap();

c.bench_function("counter_with_mapped_longer_labels_rapidhash", |b| {
b.iter(|| {
let mut labels = HashMap::with_capacity_and_hasher(3, RapidBuildHasher::default());
labels.insert("longer_field_number_two", "longer_field_number_zwei");
labels.insert("longer_field_number_one", "longer_field_number_eins");
labels.insert("longer_field_number_three", "longer_field_number_drei");
counter.with(&black_box(labels)).inc();
})
});
}

fn bench_counter_with_prepared_mapped_labels(c: &mut Criterion) {
let counter = CounterVec::new(
Opts::new("benchmark_counter", "A counter to benchmark it."),
Expand Down Expand Up @@ -216,6 +355,13 @@ criterion_group!(
bench_counter_with_label_values_concurrent_write,
bench_counter_with_mapped_labels,
bench_counter_with_mapped_labels_fnv,
bench_counter_with_mapped_labels_rapidhash,
bench_counter_with_mapped_mid_labels,
bench_counter_with_mapped_mid_labels_fnv,
bench_counter_with_mapped_mid_labels_rapidhash,
bench_counter_with_mapped_long_labels,
bench_counter_with_mapped_long_labels_fnv,
bench_counter_with_mapped_long_labels_rapidhash,
bench_counter_with_prepared_mapped_labels,
bench_int_counter_no_labels,
bench_int_counter_no_labels_concurrent_write,
Expand Down
5 changes: 4 additions & 1 deletion src/vec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ use std::collections::HashMap;
use std::hash::{BuildHasher, Hasher};
use std::sync::Arc;

use fnv::FnvHasher;
// TODO: experimenting, alternating while benchmarking
// use fnv::FnvHasher;
use rapidhash::RapidHasher as FnvHasher;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key lines to change to compare benchmarks.


use parking_lot::RwLock;

use crate::desc::{Desc, Describer};
Expand Down