Conversation
- Add 'd': 86400 to _UNITS dict in duration_utils.py - Add regression tests for days and days+hours combinations - All 9 tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
parse_durationsilently drops the days (d) unit. The README listsdas a supported unit, but the parser ignores it and returns a wrong (too-small) result.Root Cause
The
_UNITSdict induration_utils.pywas missing the entry ford(days = 86400 seconds). The regex already acceptsdas a valid unit character, so the token is matched but the value is never added to the total.Solution
Added
"d": 86400to the_UNITSdict.Tests
Added two regression tests:
test_days: Verifiesparse_duration("1d") == 86400test_days_combined: Verifiesparse_duration("2d4h") == 187200All 9 tests pass.
Bounty
Closes #1
/bounty $50