Add test to chat example #3278
Open
Add test to chat example #3278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
darth-raijin
left a comment
darth-raijin
left a comment
There was a problem hiding this comment.
Hey! Minor ideas for lifting the quality of the test
| username.clear(); | ||
| check_username(&app_state, &mut username, name); | ||
|
|
||
| assert_eq!(username, ""); |
Contributor
There was a problem hiding this comment.
The assertion could be simplified by doing the following
Suggested change
| assert_eq!(username, ""); | |
| assert!(username.is_empty()); |
| use super::*; | ||
|
|
||
| #[tokio::test] | ||
| async fn test_check_username() { |
Contributor
There was a problem hiding this comment.
I think it would be cool if the test reflected the behavior you're asserting in the test, maybe something like:
check_username_registers_unique_usernames
| assert_eq!(username, name); | ||
|
|
||
| username.clear(); | ||
| check_username(&app_state, &mut username, name); |
Contributor
There was a problem hiding this comment.
You could also assert on app_state.user_set again, to ensure the HashSet was not changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #3263.