Skip to content

Add test to chat example #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add test to chat example #3278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions examples/chat/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,3 +159,27 @@ fn check_username(state: &AppState, string: &mut String, name: &str) {
async fn index() -> Html<&'static str> {
Html(std::include_str!("../chat.html"))
}

#[cfg(test)]
mod test {
use super::*;

#[tokio::test]
async fn test_check_username() {
Copy link
Contributor

@darth-raijin darth-raijin Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be cool if the test reflected the behavior you're asserting in the test, maybe something like:
check_username_registers_unique_usernames

let user_set = Mutex::new(HashSet::new());
let (tx, _rx) = broadcast::channel(100);
let app_state = Arc::new(AppState { user_set, tx });
let mut username = String::new();
let name = "Ferris";

check_username(&app_state, &mut username, name);

assert!(app_state.user_set.lock().unwrap().contains(name));
assert_eq!(username, name);

username.clear();
check_username(&app_state, &mut username, name);
Copy link
Contributor

@darth-raijin darth-raijin Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also assert on app_state.user_set again, to ensure the HashSet was not changed


assert_eq!(username, "");
Copy link
Contributor

@darth-raijin darth-raijin Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assertion could be simplified by doing the following

Suggested change
assert_eq!(username, "");
assert!(username.is_empty());

}
}
Loading