manager: extend versionCode to Long to exceed Int.MAX#9820
Closed
Numbersf wants to merge 1 commit into
Closed
Conversation
Fixed an issue where versionCode would get stuck at 2147483647. Updated data type to Long to support larger version numbers. Some modules call multiple parameters for versionCode, causing it to reach 10 digits, which may cause issues on Android 21+. Please check for any omissions.
Collaborator
|
The documentation requires that the module version code be of type int, and I believe modules should comply with this requirement. Line 87 in 9d0b529 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where versionCode would get stuck at 2147483647. Updated data type to Long to support larger version numbers. Some modules call multiple parameters for versionCode, causing it to reach 10 digits, which may cause issues on Android 21+. Please check for any omissions.