Skip to content

manager: extend versionCode to Long to exceed Int.MAX #9820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Numbersf wants to merge 1 commit into from
Closed

manager: extend versionCode to Long to exceed Int.MAX #9820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/core/src/main/java/com/topjohnwu/magisk/core/model/UpdateInfo.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ data class UpdateInfo(
@JsonClass(generateAdapter = true)
data class ModuleJson(
val version: String,
val versionCode: Int,
val versionCode: Long,
val zipUrl: String,
val changelog: String,
)
Expand Down
4 changes: 2 additions & 2 deletions app/core/src/main/java/com/topjohnwu/magisk/core/model/module/LocalModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ data class LocalModule(
override var id: String = ""
override var name: String = ""
override var version: String = ""
override var versionCode: Int = -1
override var versionCode: Long = -1L
var author: String = ""
var description: String = ""
var updateInfo: OnlineModule? = null
Expand Down Expand Up @@ -79,7 +79,7 @@ data class LocalModule(
"id" -> id = value
"name" -> name = value
"version" -> version = value
"versionCode" -> versionCode = value.toInt()
"versionCode" -> versionCode = value.toLong()
"author" -> author = value
"description" -> description = value
"updateJson" -> updateUrl = value
Expand Down
2 changes: 1 addition & 1 deletion app/core/src/main/java/com/topjohnwu/magisk/core/model/module/Module.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ abstract class Module : Comparable<Module> {
protected set
abstract var version: String
protected set
abstract var versionCode: Int
abstract var versionCode: Long
protected set

override operator fun compareTo(other: Module) = id.compareTo(other.id)
Expand Down
2 changes: 1 addition & 1 deletion app/core/src/main/java/com/topjohnwu/magisk/core/model/module/OnlineModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ data class OnlineModule(
override var id: String,
override var name: String,
override var version: String,
override var versionCode: Int,
override var versionCode: Long,
val zipUrl: String,
val changelog: String,
) : Module(), Parcelable {
Expand Down
4 changes: 2 additions & 2 deletions docs/guides.md
View file
Open in desktop
Copy link
Copy Markdown

@tomekwiola2-ai tomekwiola2-ai Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run

Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ This is the **strict** format of `module.prop`
id=<string>
name=<string>
version=<string>
versionCode=<int>
versionCode=<long>
author=<string>
description=<string>
updateJson=<url> (optional)
Expand All @@ -103,7 +103,7 @@ Update JSON format:
```
{
"version": string,
"versionCode": int,
"versionCode": long,
"zipUrl": url,
"changelog": url
}
Expand Down